Skip to contentSkip to conversation

: Add "Warning" to the time went backwards messages

PATCH New Chris Lalancette 1 participant 1 message Mar 10, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : Add "Warning" to the time went backwards messages

All,
Attached is a patch from Prarit Bhargava, who is not subscribed to the list
(but CC'ed). His description follows:

Add "Warning" to the "Time went backwards" message.

Most QA groups (if not all) grep for specific messages in the syslog such as "Error", "Warning", "Oops".

Time went backwards is a key error which can result in system instability.

Add "Warning" to the "Time went backwards" message.

Most QA groups (if not all) grep for specific messages in the syslog such as "Error", "Warning", "Oops".

Time went backwards is a key error which can result in system instability.

arch/i386/kernel/time-xen.c +2 -2
index 532ad14..d4c8dfc 100644
@@ -665,8 +665,8 @@ irqreturn_t timer_interrupt(int irq, void *dev_id, struct pt_regs *regs)
 	if ((unlikely(delta < -(s64)permitted_clock_jitter) ||
 	     unlikely(delta_cpu < -(s64)permitted_clock_jitter))
 	    && printk_ratelimit()) {
-		printk("Timer ISR/%d: Time went backwards: "
-		       "delta=%lld delta_cpu=%lld shadow=%lld "
+		printk(KERN_WARNING "Warning Timer ISR/%d: Time went "
+		       "backwards: delta=%lld delta_cpu=%lld shadow=%lld "
 		       "off=%lld processed=%lld cpu_processed=%lld\n",
 		       cpu, delta, delta_cpu, shadow->system_timestamp,
 		       (s64)get_nsec_offset(shadow),

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel