SCTP: Remove an useless parameter from

PATCH Applied Gui Jianfeng 4 participants 6 messages Mar 28, 2008

Subsystems (3)

Networking Network drivers SCTP protocol

lore

Share & tools

lore

Gui Jianfeng

author

2008-03-28 01:53 UTC #0 lore raw

PATCH 1/1 SCTP: Remove an useless parameter from

Vlad,
There is an useless parameter in sctp_cmd_hb_timer_update, remove it.

Signed-off-by Gui Jianfeng <[email protected]>

---
 net/sctp/sm_sideeffect.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

net/sctp/sm_sideeffect.c +1 -2

index 28eb38e..5daeab5 100644
@@ -593,7 +593,6 @@ static void sctp_cmd_t3_rtx_timers_stop(sctp_cmd_seq_t *cmds,
 
 /* Helper function to update the heartbeat timer. */
 static void sctp_cmd_hb_timer_update(sctp_cmd_seq_t *cmds,
-				     struct sctp_association *asoc,
 				     struct sctp_transport *t)
 {
 	/* Update the heartbeat timer.  */

@@ -1457,7 +1456,7 @@ static int sctp_cmd_interpreter(sctp_event_t event_type,
 
 		case SCTP_CMD_HB_TIMER_UPDATE:
 			t = cmd->obj.transport;
-			sctp_cmd_hb_timer_update(commands, asoc, t);
+			sctp_cmd_hb_timer_update(commands, t);
 			break;
 
 		case SCTP_CMD_HB_TIMERS_STOP:

Signature · 5 lines

1.5.3

-- 
Regards
Gui Jianfeng

Arnaldo Carvalho de Melo

2008-03-28 02:08 UTC #1 lore raw

Em Fri, Mar 28, 2008 at 09:52:22AM +0800, Gui Jianfeng escreveu:

Quoted 22 lines

Vlad,
There is an useless parameter in sctp_cmd_hb_timer_update, remove it.

Signed-off-by Gui Jianfeng <[email protected]>

---
 net/sctp/sm_sideeffect.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

net/sctp/sm_sideeffect.c +0 -1

index 28eb38e..5daeab5 100644
@@ -593,7 +593,6 @@ static void sctp_cmd_t3_rtx_timers_stop(sctp_cmd_seq_t *cmds,
 
 /* Helper function to update the heartbeat timer. */
 static void sctp_cmd_hb_timer_update(sctp_cmd_seq_t *cmds,
-				     struct sctp_association *asoc,
 				     struct sctp_transport *t)
 {
 	/* Update the heartbeat timer.  */

net/sctp/sm_sideeffect.c static int sctp_cmd_interpreter(sctp_event_t event_type, · line 1460

Quoted 6 lines

net/sctp/sm_sideeffect.c +1 -1

@@ -1457,7 +1456,7 @@ static int sctp_cmd_interpreter(sctp_event_t event_type,
 
 		case SCTP_CMD_HB_TIMER_UPDATE:
 			t = cmd->obj.transport;
-			sctp_cmd_hb_timer_update(commands, asoc, t);
+			sctp_cmd_hb_timer_update(commands, t);
 			break;

you mean it was not compiling before?

- Arnaldo

Gui Jianfeng

author

2008-03-28 02:26 UTC #2 lore raw

Quoted 24 lines · Arnaldo Carvalho de Melo

Em Fri, Mar 28, 2008 at 09:52:22AM +0800, Gui Jianfeng escreveu:

Quoted 23 lines

Vlad,
There is an useless parameter in sctp_cmd_hb_timer_update, remove it.

Signed-off-by Gui Jianfeng <[email protected]>

---
 net/sctp/sm_sideeffect.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

net/sctp/sm_sideeffect.c +0 -1

index 28eb38e..5daeab5 100644
@@ -593,7 +593,6 @@ static void sctp_cmd_t3_rtx_timers_stop(sctp_cmd_seq_t *cmds,
 
 /* Helper function to update the heartbeat timer. */
 static void sctp_cmd_hb_timer_update(sctp_cmd_seq_t *cmds,
-				     struct sctp_association *asoc,
 				     struct sctp_transport *t)
 {
 	/* Update the heartbeat timer.  */

@@ -1457,7 +1456,7 @@ static int sctp_cmd_interpreter(sctp_event_t event_type,

Quoted 7 lines

net/sctp/sm_sideeffect.c static int sctp_cmd_interpreter(sctp_event_t event_type, · line 1460
Quoted 5 lines
net/sctp/sm_sideeffect.c +1 -1
 		case SCTP_CMD_HB_TIMER_UPDATE:
 			t = cmd->obj.transport;
-			sctp_cmd_hb_timer_update(commands, asoc, t);
+			sctp_cmd_hb_timer_update(commands, t);
 			break;
you mean it was not compiling before?

I mean this parameter is never used in this function.

Quoted 5 lines

- Arnaldo

Signature · 2 lines

Regards
Gui Jianfeng

Wang Chen

2008-03-28 02:47 UTC #4 lore raw

In reply to Arnaldo Carvalho de Melo

Arnaldo Carvalho de Melo said the following on 2008-3-28 10:07:

Quoted 24 lines

Em Fri, Mar 28, 2008 at 09:52:22AM +0800, Gui Jianfeng escreveu:

Quoted 23 lines

Vlad,
There is an useless parameter in sctp_cmd_hb_timer_update, remove it.

Signed-off-by Gui Jianfeng <[email protected]>

---
 net/sctp/sm_sideeffect.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

net/sctp/sm_sideeffect.c +0 -1

index 28eb38e..5daeab5 100644
@@ -593,7 +593,6 @@ static void sctp_cmd_t3_rtx_timers_stop(sctp_cmd_seq_t *cmds,
 
 /* Helper function to update the heartbeat timer. */
 static void sctp_cmd_hb_timer_update(sctp_cmd_seq_t *cmds,
-				     struct sctp_association *asoc,
 				     struct sctp_transport *t)
 {
 	/* Update the heartbeat timer.  */

@@ -1457,7 +1456,7 @@ static int sctp_cmd_interpreter(sctp_event_t event_type,

Quoted 8 lines

net/sctp/sm_sideeffect.c static int sctp_cmd_interpreter(sctp_event_t event_type, · line 1460
Quoted 5 lines
net/sctp/sm_sideeffect.c +1 -1
 		case SCTP_CMD_HB_TIMER_UPDATE:
 			t = cmd->obj.transport;
-			sctp_cmd_hb_timer_update(commands, asoc, t);
+			sctp_cmd_hb_timer_update(commands, t);
 			break;
you mean it was not compiling before?

Compiler can not find whether a parameter of function is used.

--
WCN

Arnaldo Carvalho de Melo

2008-03-28 02:54 UTC #3 lore raw

In reply to Gui Jianfeng

Em Fri, Mar 28, 2008 at 10:25:18AM +0800, Gui Jianfeng escreveu:

Quoted 33 lines

Quoted 24 lines · Arnaldo Carvalho de Melo
Em Fri, Mar 28, 2008 at 09:52:22AM +0800, Gui Jianfeng escreveu:
Quoted 23 lines
Vlad,
There is an useless parameter in sctp_cmd_hb_timer_update, remove it.
Signed-off-by Gui Jianfeng <[email protected]>
---
 net/sctp/sm_sideeffect.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
net/sctp/sm_sideeffect.c +0 -1
index 28eb38e..5daeab5 100644
@@ -593,7 +593,6 @@ static void sctp_cmd_t3_rtx_timers_stop(sctp_cmd_seq_t *cmds,
 
 /* Helper function to update the heartbeat timer. */
 static void sctp_cmd_hb_timer_update(sctp_cmd_seq_t *cmds,
-				     struct sctp_association *asoc,
 				     struct sctp_transport *t)
 {
 	/* Update the heartbeat timer.  */
@@ -1457,7 +1456,7 @@ static int sctp_cmd_interpreter(sctp_event_t event_type,
 
Quoted 7 lines
net/sctp/sm_sideeffect.c static int sctp_cmd_interpreter(sctp_event_t event_type, · line 1460
Quoted 5 lines
net/sctp/sm_sideeffect.c +1 -1
 		case SCTP_CMD_HB_TIMER_UPDATE:
 			t = cmd->obj.transport;
-			sctp_cmd_hb_timer_update(commands, asoc, t);
+			sctp_cmd_hb_timer_update(commands, t);
 			break;
you mean it was not compiling before?

Quoted 1 line

I mean this parameter is never used in this function.

Sorry for the disturbance, you're of course right.

- Arnaldo

Vlad Yasevich

Applied

2008-03-28 13:36 UTC #5 lore raw

In reply to Gui Jianfeng

Quoted 5 lines · Gui Jianfeng

Vlad,
There is an useless parameter in sctp_cmd_hb_timer_update, remove it.
Signed-off-by Gui Jianfeng <[email protected]>

Applied, thanks. Will push to David shortly.

-vlad