Fix unlock ordering in smp_callin
PATCH 1/1 Fix unlock ordering in smp_callin
One should normally unlock in the reverse order of the lock calls, and in this case there certainly is no reason not to.
To better see the results (with locks included), here's the complete section of corrected code:
lock_ipi_calllock();
spin_lock(&vector_lock);
/* Setup the per cpu irq handling data structures */
__setup_vector_irq(cpuid);
cpu_set(cpuid, cpu_online_map);
per_cpu(cpu_state, cpuid) = CPU_ONLINE;
spin_unlock(&vector_lock);
unlock_ipi_calllock();Signed-off-by Alan D. Brunelle <[email protected]>
--- arch/ia64/kernel/smpboot.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/ia64/kernel/smpboot.c +1 -1
@@ -400,9 +400,9 @@ smp_callin (void)/* Setup the per cpu irq handling data structures */ __setup_vector_irq (cpuid);cpu_set (cpuid, cpu_online_map); -unlock_ipi_calllock ();per_cpu (cpu_state, cpuid) =CPU_ONLINE ;spin_unlock (&vector_lock); +unlock_ipi_calllock ();smp_setup_percpu_timer ();
Signature · 1 line
1.5.2.5