Skip to contentSkip to conversation

hwmon (dme1737): probe all addresses

PATCH RESEND In review Juerg Haefliger 3 participants 3 messages Apr 4, 2008 – May 26, 2008

Subsystems (3)
Documentation Hardware monitoring DME1737 hardware monitor driver
lore
Share & tools
lore

Juerg Haefliger

author
#0 lore raw

PATCH RESEND 2/3 hwmon (dme1737): probe all addresses

This patch adds a module load parameter to enable probing of non-standard LPC addresses 0x162e and 0x164e when scanning for supported ISA chips.

Signed-off-by Juerg Haefliger <juergh at gmail.com>

This patch adds a module load parameter to enable probing of non-standard LPC addresses 0x162e and 0x164e when scanning for supported ISA chips.

Signed-off-by Juerg Haefliger <juergh at gmail.com>
Documentation/hwmon/dme1737 +4 -0
Index: linux/Documentation/hwmon/dme1737
===================================================================
@@ -22,6 +22,10 @@
 			and PWM output control functions. Using this parameter
 			shouldn't be required since the BIOS usually takes care
 			of this.
+* probe_all_addr: bool	Include non-standard LPC addresses 0x162e and 0x164e
+			when probing for ISA devices. This is required for the
+			following boards:
+			- VIA EPIA SN18000
 
 Note that there is no need to use this parameter if the driver loads without
 complaining. The driver will say so if it is necessary.
drivers/hwmon/dme1737.c +9 -1
Index: linux/drivers/hwmon/dme1737.c
===================================================================
@@ -48,6 +48,11 @@
 module_param(force_id, ushort, 0);
 MODULE_PARM_DESC(force_id, "Override the detected device ID");
 
+static int probe_all_addr;
+module_param(probe_all_addr, bool, 0);
+MODULE_PARM_DESC(probe_all_addr, "Include probing of non-standard LPC "
+		 "addresses");
+
 /* Addresses to scan */
 static const unsigned short normal_i2c[] = {0x2c, 0x2d, 0x2e, I2C_CLIENT_END};
 

@@ -2430,7 +2435,10 @@
 	}
 
 	if (dme1737_isa_detect(0x2e, &addr) &&
-	    dme1737_isa_detect(0x4e, &addr)) {
+	    dme1737_isa_detect(0x4e, &addr) &&
+	    (!probe_all_addr ||
+	     (dme1737_isa_detect(0x162e, &addr) &&
+	      dme1737_isa_detect(0x164e, &addr)))) {
 		/* Return 0 if we didn't find an ISA device */
 		return 0;
 	}

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Acked-by on v1 2/3
#1 lore raw

Re: [lm-sensors] [PATCH 2/3 RESEND] hwmon (dme1737): probe all

Quoted 5 lines · Juerg Haefliger

This patch adds a module load parameter to enable probing of non-standard LPC addresses 0x162e and 0x164e when scanning for supported ISA chips.

Signed-off-by Juerg Haefliger <juergh at gmail.com>

Looks good this time.

Acked-by Jean Delvare <[email protected]>
Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#2 lore raw

Re: [lm-sensors] [PATCH 2/3 RESEND] hwmon (dme1737): probe all

In reply to Juerg Haefliger

Hi:

Quoted 10 lines · Jean Delvare
Quoted 5 lines · Juerg Haefliger

This patch adds a module load parameter to enable probing of non-standard LPC addresses 0x162e and 0x164e when scanning for supported ISA chips.

Signed-off-by Juerg Haefliger <juergh at gmail.com>

Looks good this time.

Acked-by Jean Delvare <[email protected]>

Applied to hwmon-2.6.git/testing, thanks.

Signature · 8 lines
Mark M. Hoffman
[email protected]


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors