Skip to contentSkip to conversation

: Add some notes about per-bind-bucket sock lookup.

PATCH Applied Pavel Emelyanov 2 participants 2 messages Apr 14, 2008

Subsystems (3)
Networking Network drivers TCP
lore
Share & tools
lore

Pavel Emelyanov

author
#0 lore raw

PATCH 1/1 : Add some notes about per-bind-bucket sock lookup.

I was asked about "why don't we perform a sk_net filtering in bind_conflict calls, like we do in other sock lookup places" for a couple of times.

Can we please add a comment about why we do not need one?

Signed-off-by Pavel Emelyanov <[email protected]>
---
 net/ipv4/inet_connection_sock.c  |    7 +++++++
 net/ipv6/inet6_connection_sock.c |    4 ++++
 2 files changed, 11 insertions(+), 0 deletions(-)
net/ipv4/inet_connection_sock.c +7 -0
index 8d70cfb..828ea21 100644
@@ -55,6 +55,13 @@ int inet_csk_bind_conflict(const struct sock *sk,
 	struct hlist_node *node;
 	int reuse = sk->sk_reuse;
 
+	/*
+	 * Unlike other sk lookup places we do not check
+	 * for sk_net here, since _all_ the socks listed
+	 * in tb->owners list belong to the same net - the
+	 * one this bucket belongs to.
+	 */
+
 	sk_for_each_bound(sk2, node, &tb->owners) {
 		if (sk != sk2 &&
 		    !inet_v6_ipv6only(sk2) &&
net/ipv6/inet6_connection_sock.c +4 -0
index 78de42a..87801cc 100644
@@ -33,6 +33,10 @@ int inet6_csk_bind_conflict(const struct sock *sk,
 	const struct hlist_node *node;
 
 	/* We must walk the whole port owner list in this case. -DaveM */
+	/*
+	 * See comment in inet_csk_bind_conflict about sock lookup
+	 * vs net namespaces issues.
+	 */
 	sk_for_each_bound(sk2, node, &tb->owners) {
 		if (sk != sk2 &&
 		    (!sk->sk_bound_dev_if ||
Signature · 1 line
1.5.3.4
maintainer Applied
#1 lore raw

From: Pavel Emelyanov <[email protected]>
Date: Mon, 14 Apr 2008 13:39:46 +0400

Quoted 7 lines

I was asked about "why don't we perform a sk_net filtering in bind_conflict calls, like we do in other sock lookup places" for a couple of times.

Can we please add a comment about why we do not need one?

Signed-off-by Pavel Emelyanov <[email protected]>

Applied, thanks Pavel.