Skip to contentSkip to conversation

: Remove empty ->init callback.

PATCH Applied Pavel Emelyanov 2 participants 2 messages Apr 21, 2008

Subsystems (3)
Networking Network drivers IPv4/IPv6
lore
Share & tools
lore

Pavel Emelyanov

author
#0 lore raw

PATCH 1/1 : Remove empty ->init callback.

The netns start-stop engine can happily live with any of init or exit callbacks set to NULL.

Isn't it too late to merge this one?

Signed-off-by Pavel Emelyanov <[email protected]>

---

net/ipv6/addrconf.c +0 -7
index 8a0fd40..e591e09 100644
@@ -4338,12 +4338,6 @@ int unregister_inet6addr_notifier(struct notifier_block *nb)
 
 EXPORT_SYMBOL(unregister_inet6addr_notifier);
 
-
-static int addrconf_net_init(struct net *net)
-{
-	return 0;
-}
-
 static void addrconf_net_exit(struct net *net)
 {
 	struct net_device *dev;

@@ -4360,7 +4354,6 @@ static void addrconf_net_exit(struct net *net)
 }
 
 static struct pernet_operations addrconf_net_ops = {
-	.init = addrconf_net_init,
 	.exit = addrconf_net_exit,
 };
maintainer Applied
#1 lore raw

From: Pavel Emelyanov <[email protected]>
Date: Mon, 21 Apr 2008 19:04:00 +0400

Quoted 4 lines

The netns start-stop engine can happily live with any of init or exit callbacks set to NULL.

Isn't it too late to merge this one?

No, it fixes the bug that extraneous kernel text space is used by code that does nothing :-)

Quoted 1 line
Signed-off-by Pavel Emelyanov <[email protected]>

Applied, thanks Pavel.