Skip to contentSkip to conversation

SCTP: Add address type check while process paramaters

PATCH New Wei Yongjun 1 participant 1 message Apr 22, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 SCTP: Add address type check while process paramaters

If socket is create by AF_INET type, add IPv6 address to asoc will cause kernel panic while packet is transmitted on that transport.

This patch add address type check before process paramaters of ASCONF chunk. If peer is not support this address type, return with error invald parameter.

net/sctp/sm_make_chunk.c +13 -0
@@ -2826,6 +2826,19 @@ static __be16 sctp_process_asconf_param(
 	union sctp_addr	addr;
 	union sctp_addr_param *addr_param;
 
+	switch (addr_param->v4.param_hdr.type) {
+	case SCTP_PARAM_IPV6_ADDRESS:
+		if (!asoc->peer.ipv6_address)
+			return SCTP_ERROR_INV_PARAM;
+		break;
+	case SCTP_PARAM_IPV4_ADDRESS:
+		if (!asoc->peer.ipv4_address)
+			return SCTP_ERROR_INV_PARAM;
+		break;
+	default:
+		return SCTP_ERROR_INV_PARAM;
+	}
+
 	addr_param = (union sctp_addr_param *)
 			((void *)asconf_param + sizeof(sctp_addip_param_t));