git-send-email: Skipping - not found.
When I issue this command:
git-send-email --from Timur Tabi <[email protected]> --suppress-cc=all --to [email protected] --smtp-server remotesmtp.freescale.net 0001--PATCH-Update-CS4270-driver-to-ASoC-V2.patch
I get this output:
Skipping - not found. 0001--PATCH-Update-CS4270-driver-to-ASoC-V2.patch
OK. Log says:
Server: remotesmtp.freescale.net
MAIL FROM:<[email protected]>
RCPT TO:<[email protected]>
From: Timur Tabi <[email protected]>
To: [email protected]
Subject: [PATCH] Update CS4270 driver to ASoC V2
Date: Mon, 28 Apr 2008 16:13:34 -0500
Message-Id: <[email protected]>
X-Mailer: git-send-email 1.5.5
Result: 250 2.0.0 m3SLDY4k005131 Message accepted for delivery
I don't know enough about Perl to debug this, but I presume the problem is in this code:
for my $f (@ARGV) {
if (-d $f) {
opendir(DH,$f)
or die "Failed to opendir $f: $!";
push @files, grep { -f $_ } map { +$f . "/" . $_ }
sort readdir(DH);
} elsif (-f $f) {
push @files, $f;
} else {
print STDERR "Skipping $f - not found.\n";
}
}My guess is that "$f", at some point, is an empty string or a blank space.
Signature · 2 lines
Timur Tabi Linux kernel developer at Freescale
Quoted 5 lines · Timur Tabi
When I issue this command:
git-send-email --from Timur Tabi <[email protected]> --suppress-cc=all --to [email protected] --smtp-server remotesmtp.freescale.net 0001--PATCH-Update-CS4270-driver-to-ASoC-V2.patch
Surely that is not the command you issued, since it lacks shell quoting around your name and email address.
Quoted 6 lines
I don't know enough about Perl to debug this, but I presume the problem is in this code:
[...]
for my $f (@ARGV) {
[...]print STDERR "Skipping $f - not found.\n";
Yes, that is what is producing the error message. But that is the first time we ever look at @ARGV, let alone modify it. So the error is almost certainly caused by a blank argument being passed on the command line. And we can't debug that unless you show us the exact shell invocation that was used.
-Peff
Quoted 6 lines · Jeff King
Quoted 3 lines
git-send-email --from Timur Tabi <[email protected]> --suppress-cc=all --to [email protected] --smtp-server remotesmtp.freescale.net 0001--PATCH-Update-CS4270-driver-to-ASoC-V2.patch
Surely that is not the command you issued, since it lacks shell quoting around your name and email address.
You're right. It's the output from an "echo" command in a shell script, which likes to remove quotation marks. I keep forgetting that it does that.
Quoted 3 lines
Yes, that is what is producing the error message. But that is the first time we ever look at @ARGV, let alone modify it. So the error is almost certainly caused by a blank argument being passed on the command line.
Right again! I did a more through check of the command-line arguments, and I am sending '' as one argument on the command line.
I just rewrote my script so that it doesn't ever send a null argument. Thanks for the help.
Signature · 2 lines
Timur Tabi Linux kernel developer at Freescale