Skip to contentSkip to conversation

: Do not report false error from mesh_path_add.

PATCH In review Pavel Emelyanov 1 participant 1 message May 7, 2008

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 5/7 : Do not report false error from mesh_path_add.

In case the hash grow failed, it is not fair to return error - the new node _was_ _actually_ added in this case.

Besides, after my previous patch, this grow is more likely to fail on large hashes.

---
 net/mac80211/mesh_pathtbl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/mac80211/mesh_pathtbl.c +1 -1
index 1154398..947b13b 100644
@@ -206,7 +206,7 @@ int mesh_path_add(u8 *dst, struct net_device *dev)
 		newtbl = mesh_table_grow(mesh_paths);
 		if (!newtbl) {
 			write_unlock(&pathtbl_resize_lock);
-			return -ENOMEM;
+			return 0;
 		}
 		rcu_assign_pointer(mesh_paths, newtbl);
 		write_unlock(&pathtbl_resize_lock);
Signature · 6 lines
1.5.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html