retrans path update problem
hello everybody,
When updating retrans path(asoc->peer.retran_path), should we update the retran path to another transport even if only the original retrans path is active?
In the other words, i think, retrans path should always be changed if there are more than one transport in an association.
Am i right?
Signature · 2 lines
Regards Gui Jianfeng
Quoted 8 lines · Gui Jianfeng
hello everybody,
When updating retranspath(asoc->peer.retran_path), should we update the retran path to another transport even if only the original retrans path is active?
In the other words, i think, retrans path should always be changed if there are more than one transport in an association.Am i right?
And we do that with sctp_assoc_update_retran_path(). If we don't find another active transport, we'll still try set the retran_path to the next transport in the list.
Are you asking if we should only use ACTIVE transports?
-vlad
Quoted 8 lines · Vlad Yasevich
Quoted 7 lines · Gui Jianfeng
hello everybody,
When updating retranspath(asoc->peer.retran_path), should we update the retran path to another transport even if only the original retrans path is active?
In the other words, i think, retrans path should always be changed if there are more than one transport in an association.
Quoted 7 lines
Quoted 1 line
Am i right?
And we do that with
sctp_assoc_update_retran_path(). If we don't find another active transport, we'll still try set theretran_pathto the next transport in the list.Are you asking if we should only use ACTIVE transports?
Vlad,
I'd like to know, if the current asoc->peer.retran_path is the only active transport in the transport list, whether we should change asoc->peer.retran_path to another inactive one. The sctp_assoc_update_retran_path() won't change to a inactive transport(next one) in this scenario now, is that ok?
Quoted 5 lines
-vlad
Signature · 2 lines
Regards Gui Jianfeng
Quoted 14 lines · Gui Jianfeng
Quoted 13 lines · Vlad Yasevich
Quoted 8 lines · Gui Jianfeng
hello everybody,
When updating retranspath(asoc->peer.retran_path), should we update the retran path to another transport even if only the original retrans path is active?
In the other words, i think, retrans path should always be changed if there are more than one transport in an association.Am i right?
And we do that with
sctp_assoc_update_retran_path(). If we don't find another active transport, we'll still try set theretran_pathto the next transport in the list.
Quoted 7 lines
Quoted 1 line
Are you asking if we should only use ACTIVE transports?
Vlad,
I'd like to know, if the currentasoc->peer.retran_pathis the only active transport in the transport list, whether we should changeasoc->peer.retran_pathto another inactive one. Thesctp_assoc_update_retran_path()won't change to a inactive transport(next one) in this scenario now, is that ok?
I see now. The appears to be a bug in sctp_assoc_update_retran_path(). Even though it attempts to change to a non-active one based on this comment,
/* We have exhausted the list, but didn't find any
* other active transports. If so, use the next
* transport.
*/
it never does, since it finds the active retran_path and just uses that again.
Feel free to fix.
-vlad