Skip to contentSkip to conversation

Remove unused get_bios_map

PATCH Applied Jan Kiszka 2 participants 2 messages May 15, 2008 – May 19, 2008 KVM

lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH 1/1 Remove unused get_bios_map

Dead code since it was introduced. Is it planned to use it in the near future? Then I would suggest to put it under #if 0 for now. Otherwise, please pick up this patch.

Signed-off-by Jan Kiszka <[email protected]>
---
 qemu/kvm-tpr-opt.c |   13 -------------
 1 file changed, 13 deletions(-)
qemu/kvm-tpr-opt.c +0 -13
Index: b/qemu/kvm-tpr-opt.c
===================================================================
@@ -83,19 +83,6 @@ static void write_byte_virt(CPUState *en
     stb_phys(map_addr(&sregs, virt, NULL), b);
 }
 
-static uint32_t get_bios_map(CPUState *env, unsigned *perms)
-{
-    uint32_t v;
-    struct kvm_sregs sregs;
-
-    kvm_get_sregs(kvm_context, env->cpu_index, &sregs);
-
-    for (v = -4096u; v != 0; v -= 4096)
-	if (map_addr(&sregs, v, perms) == 0xe0000)
-	    return v;
-    return -1u;
-}
-
 struct vapic_bios {
     char signature[8];
     uint32_t virt_base;

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Applied
#1 lore raw
Quoted 4 lines · Jan Kiszka

Dead code since it was introduced. Is it planned to use it in the near future? Then I would suggest to put it under #if 0 for now. Otherwise, please pick up this patch.

Applied, thanks.

Signature · 1 line
error compiling committee.c: too many arguments to function