Skip to contentSkip to conversation

: Correctly handle device notifications for layered VLAN devices

VLAN Patrick McHardy 3 participants 3 messages May 20, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

commit cf794e6af782a838252dfc9fc6f10f7a7f66f62a

Author: Patrick McHardy <[email protected]>
Date:   Tue May 20 15:12:49 2008 +0200

[VLAN]: Correctly handle device notifications for layered VLAN devices

Commit 30688a9 ([VLAN]: Handle vlan devices net namespace changing) changed the device notifier to special-case notifications for VLAN devices, effectively disabling state propagation to underlying VLAN devices. This is needed for layered VLANs though, so restore the original behaviour.

net/8021q/vlan.c +1 -3
index 2a739ad..b934159 100644
@@ -410,10 +410,8 @@ static int vlan_device_event(struct notifier_block *unused, unsigned long event,
 	int i, flgs;
 	struct net_device *vlandev;
 
-	if (is_vlan_dev(dev)) {
+	if (is_vlan_dev(dev))
 		__vlan_device_event(dev, event);
-		goto out;
-	}
 
 	grp = __vlan_find_group(dev);
 	if (!grp)
#1 lore raw
Quoted 6 lines · Patrick McHardy

commit cf794e6af782a838252dfc9fc6f10f7a7f66f62a

Author: Patrick McHardy <[email protected]>
Date:   Tue May 20 15:12:49 2008 +0200

[VLAN]: Correctly handle device notifications for layered VLAN devices

Quoted 7 lines

Commit 30688a9 ([VLAN]: Handle vlan devices net namespace changing) changed the device notifier to special-case notifications for VLAN devices, effectively disabling state propagation to underlying VLAN devices. This is needed for layered VLANs though, so restore the original behaviour.

maintainer
#2 lore raw

From: Pavel Emelyanov <[email protected]>
Date: Tue, 20 May 2008 17:25:47 +0400

Quoted 13 lines
Quoted 12 lines · Patrick McHardy

commit cf794e6af782a838252dfc9fc6f10f7a7f66f62a

Author: Patrick McHardy <[email protected]>
Date:   Tue May 20 15:12:49 2008 +0200

[VLAN]: Correctly handle device notifications for layered VLAN devices

Commit 30688a9 ([VLAN]: Handle vlan devices net namespace changing) changed the device notifier to special-case notifications for VLAN devices, effectively disabling state propagation to underlying VLAN devices. This is needed for layered VLANs though, so restore the original behaviour.

Quoted 3 lines
Quoted 1 line

Applied and I'll queue up to -stable if relevant...

Thanks!