Skip to contentSkip to conversation

libata: SRST can't be trusted on PMP sil3726

PATCH Applied Tejun Heo 2 participants 3 messages May 21, 2008 – May 30, 2008 libata

lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 libata: SRST can't be trusted on PMP sil3726

As in sil4726, SRST can't be trusted on sil3726 causing detection problems under certain configuraitons. I thought it was from the Config Disk device but apparently not.

---
drivers/ata/libata-pmp.c | 7 +++++--

1 file changed, 5 insertions(+), 2 deletions(-)
drivers/ata/libata-pmp.c +0 -0
index 3374ec5..b65db30 100644
@@ -322,9 +322,12 @@ static void sata_pmp_quirks(struct ata_port *ap)
	if (vendor == 0x1095 && devid == 0x3726) {
		/* sil3726 quirks */
		ata_port_for_each_link(link, ap) {

- /* class code report is unreliable */
+ /* Class code report is unreliable and SRST
+ * times out under certain configurations.
+ */

			if (link->pmp < 5)

- link->flags |= ATA_LFLAG_ASSUME_ATA;
+ link->flags |= ATA_LFLAG_NO_SRST |
+ ATA_LFLAG_ASSUME_ATA;

			/* port 5 is for SEMB device and it doesn't like SRST */
			if (link->pmp == 5)
author
#1 lore raw
Quoted 5 lines · Tejun Heo

As in sil4726, SRST can't be trusted on sil3726 causing detection problems under certain configuraitons. I thought it was from the Config Disk device but apparently not.

Ping.

Signature · 1 line
tejun
Applied
#2 lore raw
In reply to Tejun Heo
Quoted 8 lines · Tejun Heo

As in sil4726, SRST can't be trusted on sil3726 causing detection problems under certain configuraitons. I thought it was from the Config Disk device but apparently not.

---
drivers/ata/libata-pmp.c | 7 +++++--

1 file changed, 5 insertions(+), 2 deletions(-)

applied