Skip to contentSkip to conversation

Fix endianess conversion in usb_ohci.c

U-Boot-Users Christian Eggers 3 participants 3 messages May 21, 2008 – Jul 7, 2008 USB

lore
Share & tools
lore
#0 lore raw

I think this must be swapped (result may be equal).

---
 drivers/usb/usb_ohci.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/usb/usb_ohci.c +3 -3
index ee0f2e4..29fcbbe 100644
@@ -1218,9 +1218,9 @@ pkt_print(NULL, dev, pipe, buffer, trans
 	}
 
 	bmRType_bReq  = cmd->requesttype | (cmd->request << 8);
-	wValue	      = cpu_to_le16 (cmd->value);
-	wIndex	      = cpu_to_le16 (cmd->index);
-	wLength	      = cpu_to_le16 (cmd->length);
+	wValue	      = le16_to_cpu (cmd->value);
+	wIndex	      = le16_to_cpu (cmd->index);
+	wLength	      = le16_to_cpu (cmd->length);
 
 	info("Root-Hub: adr: %2x cmd(%1x): %08x %04x %04x %04x",
 		dev->devnum, 8, bmRType_bReq, wValue, wIndex, wLength);
Signature · 1 line
1.4.3.4
#1 lore raw
Quoted 4 lines · In message <[email protected]> you wrote:

I think this must be swapped (result may be equal).

---
 drivers/usb/usb_ohci.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Markus, can you please comment on this patch?

Thanks in advance.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You can observe a lot just by watchin'.                  - Yogi Berra
#2 lore raw

Dear Wolfgang,

Sorry for the delay, I was on holiday too.

Quoted 7 lines · Wolfgang Denk
Quoted 4 lines · In message <[email protected]> you wrote:

I think this must be swapped (result may be equal).

---
 drivers/usb/usb_ohci.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Markus, can you please comment on this patch?

I believe this was merged as commit fb63939b

Viele Gr??e / Best regards

Markus Klotzb?cher

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de