Skip to contentSkip to conversation

can UBIFS be taken to linux-next?

DISCUSSION Artem Bityutskiy 4 participants 5 messages May 27, 2008 – May 28, 2008

lore
Share & tools
lore
#0 lore raw

Hi Stephen,

we would like to ask for UBIFS mainline inclusion the next merge window. Of course we cannot say for sure whether Linus will merge it or not, but it would be helpful to have it in your tree for some time anyway. UBIFS is already in -mm tree so I assume it should not have too many build issues.

In case you do agree, here is the URL (for_andrew branch):

git://git.infradead.org/~dedekind/ubifs-2.6.git for_andrew

Signature · 2 lines
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
#1 lore raw

Hi Artem,

Quoted 6 lines · On Tue, 27 May 2008 09:18:07 +0300 Artem Bityutskiy…

we would like to ask for UBIFS mainline inclusion the next merge window. Of course we cannot say for sure whether Linus will merge it or not, but it would be helpful to have it in your tree for some time anyway. UBIFS is already in -mm tree so I assume it should not have too many build issues.

OK, my requirements are that you intend for it to be integrated in the next merge window, that it be reviewed and that it be unit tested (i.e. tested as well as you can in isolation). You seem to have done all that, so I will add it.

I will put it at the end of the merge today.

Andrew, does that make sense to you?

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#2 lore raw
Quoted 10 lines · On Wed, 28 May 2008 11:41:12 +1000 Stephen Rothwell <[email protected]>…

Hi Artem,

Quoted 6 lines · On Tue, 27 May 2008 09:18:07 +0300 Artem Bityutskiy…

we would like to ask for UBIFS mainline inclusion the next merge window. Of course we cannot say for sure whether Linus will merge it or not, but it would be helpful to have it in your tree for some time anyway. UBIFS is already in -mm tree so I assume it should not have too many build issues.

Quoted 8 lines

OK, my requirements are that you intend for it to be integrated in the next merge window, that it be reviewed and that it be unit tested (i.e. tested as well as you can in isolation). You seem to have done all that, so I will add it.

I will put it at the end of the merge today.

Andrew, does that make sense to you?

I'm not aware of any issues which would block a 2.6.27 merge.

I haven't reviewed the filesystem myself. Christoph Hellwig seems to have had a good go through it and had numerous review comments, but it is unclear what stage things are at with addressing them?

#3 lore raw
Quoted 5 lines · Andrew Morton

I'm not aware of any issues which would block a 2.6.27 merge.

I haven't reviewed the filesystem myself. Christoph Hellwig seems to have had a good go through it and had numerous review comments, but it is unclear what stage things are at with addressing them?

Indeed Christoph made a good go through and we appreciate this. We have addressed most of his requests. I'll just cite the latest UBIFS submit mail (http://marc.info/?l=linux-kernel&m=121180458401234&w=2):

* Requests from Christoph Hellwig's review (may be found here:
http://marc.info/?l=linux-kernel&m=121093446502796&w=2). Few things related to the background thread were not done though. Here are explanations why: http://marc.info/?l=linux-kernel&m=121155640026661&w=2
and http://marc.info/?l=linux-kernel&m=121119680522445&w=2 (see end of the mail).
Also, we have not changed readdir() implementation so far, but just put a comment that we cannot support NFS at the moment. However, we have an idea how to fix this, but need some comments from the community. We'll send a separate mail describing the problem and the possible solution shortly. Nevertheless, this should not be a blocker.

We are currently working on "state-less" (in Christoph's terminology) readdir() implementation. Here is what we are doing:
http://marc.info/?l=linux-kernel&m=121181030711128&w=2

Would be nice to get some comments on 2 possible issues which will be present in the new implementation.

Signature · 2 lines
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
#4 lore raw
In reply to Stephen Rothwell
Quoted 2 lines · Stephen Rothwell

OK, my requirements are that you intend for it to be integrated in the next merge window,

Yes.

Quoted 1 line

that it be reviewed

We have not got too much review, just because there are not so many people involved into the area. But we have got some review. The best one was from Christoph Hellwig.

Quoted 2 lines

and that it be unit tested (i.e.
tested as well as you can in isolation).

Yes, we do this on regular basis. We have our own tests [1] ans we use older JFFS2 tests [2]. We also use it in Nokia and we have several users in the community.

Quoted 2 lines

You seem to have done all that,
so I will add it.

Thanks.

[1] git://git.infradead.org/~dedekind/ubifs-userspace.git
or http://git.infradead.org/users/dedekind/ubifs-userspace.git
[2] git://git.infradead.org/mtd-utils.git
or http://git.infradead.org/mtd-utils.git

Signature · 2 lines
Best Regards,
Artem Bityutskiy (Артём Битюцкий)