Skip to contentSkip to conversation

6a4be75aa84b0bea7939bca1af112fb3c2dfd86e make my gcc (still 4.2) unhappy ;<(

DISCUSSION rubisher 2 participants 4 messages May 29, 2008

lore
Share & tools
lore

rubisher

author
#0 lore raw

Hello Kyle,

This hunk:
+
+/* from pacache.S -- needed for copy_page */
+extern void copy_user_page_asm(void);
+EXPORT_SYMBOL(copy_user_page_asm);

made my 32bit kernel build failing because:
<./include/asm-parisc/page.h>

contains this prototype:

void copy_user_page_asm(void *to, void *from);

I so tried:
+extern void copy_user_page_asm(void *to, void *from);

and it seems to help to build a bootable kernel on my b2k but I ignore if it's the right stuff to do?

Tia,

	r.
#1 lore raw

Review

Quoted 8 lines · rubisher

Hello Kyle,

This hunk:

(quoted diff) +4 -0
+
+/* from pacache.S -- needed for copy_page */
+extern void copy_user_page_asm(void);
+EXPORT_SYMBOL(copy_user_page_asm);

yeah, i know, i've been too busy trying to figure out why gcc 4.3 is fucked to push a new commit.

i'll do that later today though.

r, kyle

author
#2 lore raw
Quoted 11 lines · Kyle McMartin

Review

Quoted 8 lines · rubisher

Hello Kyle,

This hunk:

(quoted diff) +4 -0
+
+/* from pacache.S -- needed for copy_page */
+extern void copy_user_page_asm(void);
+EXPORT_SYMBOL(copy_user_page_asm);

yeah, i know,

Oops, sorry.

Quoted 3 lines

i've been too busy trying to figure out why gcc 4.3 is fucked to push a new commit.

I would so like to be helpfull but haven't anymore enough time for this investigation, sorry.

Quoted 2 lines

i'll do that later today though.

No pb.

Tx,

	r.
Quoted 3 lines

r, kyle

#3 lore raw
Quoted 12 lines · rubisher
Quoted 11 lines · Kyle McMartin

Review

Quoted 8 lines · rubisher

Hello Kyle,

This hunk:

(quoted diff) +4 -0
+
+/* from pacache.S -- needed for copy_page */
+extern void copy_user_page_asm(void);
+EXPORT_SYMBOL(copy_user_page_asm);

yeah, i know,

Quoted 7 lines

Oops, sorry.

Quoted 3 lines

i've been too busy trying to figure out why gcc 4.3 is fucked to push a new commit.

I would so like to be helpfull but haven't anymore enough time for this investigation, sorry.

it's ok, i appreciate all the effort you've put in so far :)

cheers, kyle