Skip to contentSkip to conversation

More e820 unification?

DISCUSSION Jeremy Fitzhardinge 2 participants 4 messages Jun 2, 2008

lore
Share & tools
lore
#0 lore raw

Hi,

Are you looking at completely unifying e820_32/64.c? It looks like the delta between them is fairly small.

Thanks,
J

#1 lore raw
Quoted 4 lines · Jeremy Fitzhardinge

Hi,

Are you looking at completely unifying e820_32/64.c? It looks like the delta between them is fairly small.

Yes. but need to wait some pending bugs that is numa32 related get fixed..

next is find_max_pfn and end_of_e820_ram...( memory_present is moved out of find_max_pfn)...

BTW:
[PATCH] x86: cleanup max_pfn_mapped usage - 32bit
may need you update xen pv to specify max_pfn_mapped early stage...

Thanks

YH

#2 lore raw
Quoted 2 lines · Yinghai Lu

[PATCH] x86: cleanup max_pfn_mapped usage - 32bit
may need you update xen pv to specify max_pfn_mapped early stage...

Ah, yes, I saw your mail. What exactly does that value mean? What should I set it to?

J

#3 lore raw
Quoted 7 lines · Jeremy Fitzhardinge
Quoted 3 lines · Yinghai Lu

[PATCH] x86: cleanup max_pfn_mapped usage - 32bit
may need you update xen pv to specify max_pfn_mapped early stage...

Ah, yes, I saw your mail. What exactly does that value mean? What should I set it to?

arch/x86/kernel/head_32.S doesn't know max_low_pfn yet, so it could initialize initial_pg_table to cover much less of the max_low_pfn. it will need paging_init/pagetable_init/kernel_phys... to initialize mapping to max_low_pfn.
but that is too late. it said need to use alloc_bootmem_low_pages to get bootmem, other wise even you can get it > mem_mapped, you can not use.
two memory region must be get via find_e820_area even before bootmem is there. bootmap for bootmem, and pgdat for node0 in numa_32. so it need to take the really mapped as parameter for that func, instead of max_low_pfn.

We can get the real max_pfn_mapped in head_32.S when finish the initial page table.

for XEN PV, when you are preparing the init pg table in domain builder, you should keep the max_pfn_mapped ...

64 bit doesn't need that, because it call init_memory_mapping very earlier..., and it cover all memory.

YH