Skip to contentSkip to conversation

pcspkr: undepend of snd-pcsp

PATCH RESEND In review Stas Sergeev 2 participants 3 messages Jun 7, 2008 Input drivers

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 pcspkr: undepend of snd-pcsp

Once again this mail returns to me
as a spam, without reaching Dmitry :(

Hello.

It should be possible to build
pcspkr driver together with snd-pcsp.
Even though right now there is no
good plan to get these drivers to
work together, some things were done,
namely:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=16dc42e018c2868211b4928f20a957c0c216126c
and
https://bugzilla.redhat.com/show_bug.cgi?id=448425
which looks more or less sufficient.

And there was a discussion already:
http://kerneltrap.org/mailarchive/linux-kernel/2008/4/29/1652654

The attached patch allows pcspkr to
be built together with snd-pcsp.

Dmitry, could you please apply?

------
Allow pcspkr to be built together with snd-pcsp.
The bug in a driver core that prevented this in
the past, is now fixed by
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=16dc42e018c2868211b4928f20a957c0c216126c

drivers/input/misc/Kconfig +0 -1
index 3ad8bd9..432699d 100644
@@ -15,7 +15,6 @@ if INPUT_MISC
 config INPUT_PCSPKR
 	tristate "PC Speaker support"
 	depends on PCSPKR_PLATFORM
-	depends on SND_PCSP=n
 	help
 	  Say Y here if you want the standard PC Speaker to be used for
 	  bells and whistles.
maintainer
#1 lore raw

Hi Sergey,

This is wierd, I have all 3 your mails :) The patch is in the 'for-linus' branch of my tree and should be in mainline next time I ask Linus to pull.

Dmitry

Quoted 35 lines · Stas Sergeev

Once again this mail returns to me
as a spam, without reaching Dmitry :(

Hello.

It should be possible to build
pcspkr driver together with snd-pcsp.
Even though right now there is no
good plan to get these drivers to
work together, some things were done,
namely:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=16dc42e018c2868211b4928f20a957c0c216126c
and
https://bugzilla.redhat.com/show_bug.cgi?id=448425
which looks more or less sufficient.

And there was a discussion already:
http://kerneltrap.org/mailarchive/linux-kernel/2008/4/29/1652654

The attached patch allows pcspkr to
be built together with snd-pcsp.

Dmitry, could you please apply?

------
Allow pcspkr to be built together with snd-pcsp.
The bug in a driver core that prevented this in
the past, is now fixed by
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=16dc42e018c2868211b4928f20a957c0c216126c

Signature · 1 line
Dmitry
#2 lore raw

Hello.

Quoted 4 lines · Dmitry Torokhov

Hi Sergey,
This is wierd, I have all 3 your mails :) The patch is in the 'for-linus' branch of my tree and should be in mainline next time I ask Linus to pull.

Thanks, but I am not Sergey, and
I really got these mails back:
---
<[email protected]>: delivery temporarily suspended: host

    mx1.comcast.net[76.96.62.116] refused to talk to me: 554
    IMTA27.westchester.pa.mail.comcast.net comcast 62.5.255.48 Comcast BL004
    Blocked for spam.  Please see
    http://www.comcast.net/help/faq/index.jsp?faq=SecurityMail_Policy18628

---

But if you already applied it, then
there is nothing to worry. :)