cleanup pleonasm in unaligned.c
PATCH 1/1 cleanup pleonasm in unaligned.c
Hello Carlos, Kyle,
Trying to refresh my memory about gcc "memory" clobber, I just figure out that I missed what looks to me a useless redundancy in some FIXUP_BRANCH_CLOBBER usage in the mentioned file:
you did well:
#define FIXUP_BRANCH_CLOBBER "r1"
I think so what is following is just a cleanup which wouldn't affect the generated code, even thought:
b/arch/parisc/kernel/unaligned.c renamed from a/arch/parisc/kernel/unaligned.c +3 -3
@@ -350,7 +350,7 @@ ASM_EXCEPTIONTABLE_ENTRY(2b,4b) : "=r" (ret) : "r" (val), "r" (regs->ior), "r" (regs->isr) - : "r19", "r20", "r21", "r22", "r1", FIXUP_BRANCH_CLOBBER ); + : "r19", "r20", "r21", "r22", FIXUP_BRANCH_CLOBBER );return 0 ; }
@@ -402,7 +402,7 @@ ASM_EXCEPTIONTABLE_ENTRY(4b,6b) : "=r" (ret) : "r" (val), "r" (regs->ior), "r" (regs->isr) - : "r19", "r20", "r21", "r22", "r1", FIXUP_BRANCH_CLOBBER ); + : "r19", "r20", "r21", "r22", FIXUP_BRANCH_CLOBBER );#else {unsigned long valh=(val>>32 ),vall=(val&0xffffffffl );
@@ -437,7 +437,7 @@ ASM_EXCEPTIONTABLE_ENTRY(5b,7b) : "=r" (ret) : "r" (valh), "r" (vall), "r" (regs->ior), "r" (regs->isr) - : "r19", "r20", "r21", "r1", FIXUP_BRANCH_CLOBBER ); + : "r19", "r20", "r21", FIXUP_BRANCH_CLOBBER ); }#endif
=== <> ===
What's your opinion?
Cheers,
r.