CDC_PLAY_AUDIO check in cdrom_count_tracks() and other oddities
Hello, Jens.
I'm tracking down a bug where HAL doesn't mount media automatically. It turned out that CDROM_DISC_STATUS wasn't reporting correct disc type which was caused by CDC_PLAY_AUDIO check failure at the top of cdrom_count_tracks().
I've went through MMC-3 but couldn't find anything which associates play audio capability with READ_TOC. READ_TOC was mandatory command, so according to MMC-3, there's no reason to avoid issuing READ_TOC on !CDC_PLAY_AUDIO. Is there something I don't know?
Thanks.
Signature · 1 line
tejun
Quoted 11 lines · Tejun Heo
Hello, Jens.
I'm tracking down a bug where HAL doesn't mount media automatically. It turned out that
CDROM_DISC_STATUSwasn't reporting correct disc type which was caused byCDC_PLAY_AUDIOcheck failure at the top ofcdrom_count_tracks().I've went through MMC-3 but couldn't find anything which associates play audio capability with
READ_TOC.READ_TOCwas mandatory command, so according to MMC-3, there's no reason to avoid issuingREAD_TOCon !CDC_PLAY_AUDIO. Is there something I don't know?
That check predates me :-)
I can't imagine drives NOT having READ_TOC, so I don't think it's a problem to remove the depedency on CDC_PLAY_AUDIO.
Signature · 1 line
Jens Axboe