Skip to contentSkip to conversation

rework of "prioritize non-migratabletasks over migratable ones"

sched-devel, patch-rfc Gregory Haskins 1 participant 1 message Jun 13, 2008

lore
Share & tools
lore
#0 lore raw

Sorry for topposting....still on vaca via blackberry..

I am in favor of dropping too...this patch was really just an RFC in response to Dmity's observation....its probably too premature to include this type of thing, if ever at all..

-Greg
-----Original Message-----
From: Peter Zijlstra <[email protected]>
Cc: Ingo Molnar <[email protected]>
To: Dmitry Adamushko <[email protected]>
Cc: Steven Rostedt <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Gregory Haskins <[email protected]>
Cc: <[email protected]>

Sent: 6/13/2008 7:08:04 AM
Subject: Re: [sched-devel, patch-rfc] rework of "prioritize non-migratabletasks over migratable ones"

Quoted 29 lines · Dmitry Adamushko

2008/6/11 Peter Zijlstra <[email protected]>:

Quoted 13 lines · Dmitry Adamushko
Quoted 12 lines

Hi Gregory,

regarding this commit: 45c01e824991b2dd0a332e19efc4901acb31209f

I think we can do it simpler. Please take a look at the patch below.

Instead of having 2 separate arrays (which is + ~800 bytes on x86_32 and twice so on x86_64), let's add "exclusive" (the ones that are bound to this CPU) tasks to the head of the queue and "shared" ones -- to the end.

Quoted 6 lines
Quoted 3 lines

In case of a few newly woken up "exclusive" tasks, they are 'stacked' (not queued as now), meaning that a task {i+1} is being placed in front of the previously woken up task {i}. But I don't think that this behavior may cause any realistic problems.

Doesn't this violate POSIX ?

If so, then the idea of "prioritize non-migratable tasks over migratable ones" violates it, not just an artefact of this particular implementation.

No matter which implementation is used, we have a situation when a woken-up single-CPU-bound task (let's call it 'p') can preempt a current task with effects as follows:

Quoted 8 lines

- 'current' is not guaranteed to get another CPU;

- there might have been other pending tasks (of equal prio) on this queue. As a result, 'p' starts running before them violating currently used (explicitly requested by POSIX?) round-robin behavior.

We may just consider dropping this idea completely. (my 0.02$)

If we cannot guarantee POSIX compliant scheduling I think we should get rid of this.