Skip to contentSkip to conversation

odd timing bug with cgroups?

DISCUSSION Chris Friesen 2 participants 4 messages Jun 13, 2008 – Jun 16, 2008

lore
Share & tools
lore
#0 lore raw

I'm seeing some odd behaviour in the case where a parent task forks a child and then immediately attempts to put the child into a group.

It appears that there is a window after task creation where the child task is in "limbo" such that the parent cannot put it into a group. If I run the parent under "strace" or else sleep for a bit before trying to put the child into a group, then everything works fine.

This seems odd...I would think that as soon as the fork() call returns in the parent we should be able to put that task into a group.

I'm just starting to look at the code, but I thought I'd mention it in case someone knows exactly where to look.

Chris

#1 lore raw
Quoted 2 lines · Chris Friesen

This seems odd...I would think that as soon as the fork() call returns in the parent we should be able to put that task into a group.

I'm admittedly shooting in the dark here, but remember that a successful fork() call returns *twice*. Just because the *parent* has returned doesn't mean that the *child* has finished all the processing and returned as well - it may be delayed by other kernel threads etc and still not quite ready for tweaking.

It sounds like a variant of the race conditions we had a while back where lots of programs blew chunks when we started having "child runs first" semantics so children could run and exit before the parent was ready for it?

#2 lore raw
Quoted 9 lines · [email protected] wrote:
Quoted 1 line · Chris Friesen

This seems odd...I would think that as soon as the fork() call returns in the parent we should be able to put that task into a group.

I'm admittedly shooting in the dark here, but remember that a successful fork() call returns *twice*. Just because the *parent* has returned doesn't mean that the *child* has finished all the processing and returned as well - it may be delayed by other kernel threads etc and still not quite ready for tweaking.

I was thinking something like this as well, like maybe we can't move the child to another group until it gets scheduled in once, or something similar.

If that is the case, I think it's a bug--on return from fork() the child's pid is visible (because the parent knows it) and so it should be valid to use for any operation that takes a pid.

Chris

#3 lore raw

Re: odd timing bug with cgroups -- solved

Quoted 1 line · Chris Friesen

I was thinking something like this as well, like maybe we can't move the child to another group until it gets scheduled in once, or something similar.

Well, it appears I was way off base. My main task is SCHED_RR, and my child tasks put themselves into SCHED_OTHER. I didn't have any realtime groups configured, so it was bailing out in the first conditional in cpu_cgroup_can_attach().

By also having the parent put the children into SCHED_OTHER, my testcase will handle both cases (parent or child runs first) and everything seems to be working fine.

Chris