Skip to contentSkip to conversation

change EARLY_PRINTK default to n

PATCH In review David Pelton 2 participants 3 messages Jun 16, 2008 – Jul 30, 2008 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 change EARLY_PRINTK default to n

This patch changes the default for CONFIG_EARLY_PRINTK to n. Prior to this change, the presence of SYS_HAS_EARLY_PRINTK would always set EARLY_PRINTK to y if either EMBEDDED or DEBUG_KERNEL were not set. As this is a debugging option, it should default to n.

---

Hi,

while fiddling with kernel configuration options for the Broadcom eval board I am working with, I noticed that turning off DEBUG_KERNEL would make many bad things happen. I did not get to the root cause, but I think that some of the early printk drivers have some dependency on functionality enabled by DEBUG_KERNEL. The 2.6.25.6 kernel has a default value of "y" for EARLY_PRINTK, and this default will be applied anytime the platform claims to support early printk. In particular, if DEBUG_KERNEL is not selected, there is no way to disable EARLY_PRINTK. This patch changes the default to "n" to avoid these problems.

- David Pelton

arch/mips/Kconfig | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/Kconfig 2008-06-16 14:34:33.229160000 -0400 renamed from arch/mips/Kconfig 2008-06-09 14:27:19.000000000 -0400 +0 -0
diff -Nraup linux-2.6.25.6-clean/arch/mips/Kconfig linux-2.6.25.6/arch/mips/Kconfig
@@ -807,7 +807,7 @@ config DMA_NEED_PCI_MAP_STATE

config EARLY_PRINTK
bool "Early printk" if EMBEDDED && DEBUG_KERNEL
depends on SYS_HAS_EARLY_PRINTK
- default y
+ default n
help
This option enables special console drivers which allow the kernel to print messages very early in the bootup process.

Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · David Pelton

This patch changes the default for CONFIG_EARLY_PRINTK to n. Prior to this change, the presence of SYS_HAS_EARLY_PRINTK would always set EARLY_PRINTK to y if either EMBEDDED or DEBUG_KERNEL were not set. As this is a debugging option, it should default to n.

Ralf, any problem with this patch?

---
Atsushi Nemoto

#2 lore raw
Quoted 10 lines · Atsushi Nemoto
Quoted 6 lines

This patch changes the default for CONFIG_EARLY_PRINTK to n. Prior to this change, the presence of SYS_HAS_EARLY_PRINTK would always set EARLY_PRINTK to y if either EMBEDDED or DEBUG_KERNEL were not set. As this is a debugging option, it should default to n.

Ralf, any problem with this patch?

Oops, the patch cannot be applied due to tab/space issue. But it can be fixed easily :)

---
Atsushi Nemoto