Skip to contentSkip to conversation

perfmon2 minimal v2: base code

PATCH In review [email protected] 2 participants 3 messages Jun 17, 2008 – Jun 23, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/19 perfmon2 minimal v2: base code

This patch adds the core functions of the perfmon2 subsystem. It creates the toplevel perfmon subdirectory where all perfmon2 generic code lives. Core functions implements initialization, session allocation and terminations.

--

perfmon/Makefile new file +7 -0
Index: o/perfmon/Makefile
===================================================================
@@ -0,0 +1,7 @@
+#
+# Copyright (c) 2005-2006 Hewlett-Packard Development Company, L.P.
+# Contributed by Stephane Eranian <[email protected]>
+#
+obj-$(CONFIG_PERFMON) = perfmon_ctx.o \
+			perfmon_file.o perfmon_attach.o 	\
+			perfmon_res.o perfmon_init.o
perfmon/perfmon_attach.c new file +86 -0

86 lines not on this page · raw message

perfmon/perfmon_ctx.c new file +164 -0

164 lines not on this page · raw message

perfmon/perfmon_file.c new file +94 -0

94 lines not on this page · raw message

perfmon/perfmon_init.c new file +87 -0

87 lines not on this page · raw message

perfmon/perfmon_priv.h new file +119 -0

119 lines not on this page · raw message

perfmon/perfmon_res.c new file +105 -0

105 lines not on this page · raw message

Makefile +1 -1
Index: o/Makefile
===================================================================
@@ -607,7 +607,7 @@
 
 
 ifeq ($(KBUILD_EXTMOD),)
-core-y		+= kernel/ mm/ fs/ ipc/ security/ crypto/ block/
+core-y		+= kernel/ mm/ fs/ ipc/ security/ crypto/ block/ perfmon/
 
 vmlinux-dirs	:= $(patsubst %/,%,$(filter %/, $(init-y) $(init-m) \
 		     $(core-y) $(core-m) $(drivers-y) $(drivers-m) \
include/linux/sched.h +3 -0
Index: o/include/linux/sched.h
===================================================================
@@ -1303,6 +1303,9 @@
 	int latency_record_count;
 	struct latency_record latency_record[LT_SAVECOUNT];
 #endif
+#ifdef CONFIG_PERFMON
+	struct pfm_context *pfm_context;
+#endif
 };
 
 /*
#1 lore raw

Hi Stephane,

Quoted 13 lines · On Tue, 17 Jun 2008 15:02:10 -0700 (PDT) [email protected] wrote:

+++ o/perfmon/Makefile 2008-06-17 08:33:23.000000000 +0200

perfmon/Makefile new file +8 -0
@@ -0,0 +1,7 @@
+#
+# Copyright (c) 2005-2006 Hewlett-Packard Development Company, L.P.
+# Contributed by Stephane Eranian <[email protected]>
+#
+obj-$(CONFIG_PERFMON) = perfmon_ctx.o \
+			perfmon_file.o perfmon_attach.o 	\
+			perfmon_res.o perfmon_init.o
 
+++ o/Makefile	2008-06-17 08:34:19.000000000 +0200

perfmon/Makefile line 610

Quoted 5 lines
perfmon/Makefile new file +1 -1
@@ -607,7 +607,7 @@
 
 
 ifeq ($(KBUILD_EXTMOD),)
-core-y		+= kernel/ mm/ fs/ ipc/ security/ crypto/ block/
+core-y		+= kernel/ mm/ fs/ ipc/ security/ crypto/ block/ perfmon/

Is there some reason that this is not

core-$(CONFIG_PERFMON) += perfmon/

and then you could just use "obj-y" in perfmon/Makefile

Or are there going to be things in perfmon/ that need building if CONFIG_PERFMON is not set?

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#2 lore raw

Stephen,

This is a good comment. I check the perfmon subdir and there is indeed no need to go
there when CONFIG_PERFMON is not set. I have made the change now.

Thanks.

Quoted 36 lines · Stephen Rothwell

Hi Stephane,

Quoted 13 lines · On Tue, 17 Jun 2008 15:02:10 -0700 (PDT) [email protected] wrote:

+++ o/perfmon/Makefile 2008-06-17 08:33:23.000000000 +0200

perfmon/Makefile new file +8 -0
@@ -0,0 +1,7 @@
+#
+# Copyright (c) 2005-2006 Hewlett-Packard Development Company, L.P.
+# Contributed by Stephane Eranian <[email protected]>
+#
+obj-$(CONFIG_PERFMON) = perfmon_ctx.o \
+                     perfmon_file.o perfmon_attach.o         \
+                     perfmon_res.o perfmon_init.o
 
+++ o/Makefile        2008-06-17 08:34:19.000000000 +0200

perfmon/Makefile line 610

Quoted 5 lines
perfmon/Makefile new file +1 -1
@@ -607,7 +607,7 @@
 
 
 ifeq ($(KBUILD_EXTMOD),)
-core-y               += kernel/ mm/ fs/ ipc/ security/ crypto/ block/
+core-y               += kernel/ mm/ fs/ ipc/ security/ crypto/ block/ perfmon/

Is there some reason that this is not

core-$(CONFIG_PERFMON) += perfmon/

and then you could just use "obj-y" in perfmon/Makefile

Or are there going to be things in perfmon/ that need building if CONFIG_PERFMON is not set?

--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/