Skip to contentSkip to conversation

KVM fixes for 2.6.26-rc7

GIT PULL Avi Kivity 8 participants 27 messages Jun 24, 2008 – Jun 30, 2008 KVM

lore
Share & tools
lore

Avi Kivity

author
#0 lore raw

Linus, please pull from the repo and branch at:

git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git
kvm-updates-2.6.26

to receive kvm updates for 2.6.26-rc7. The patches fix host oopses, guest interrupt loss, and total kvm clock borkage.

Since one of the goals of kvm clock was to be binary compatible with the Xen clock, the patchset moves the Xen time code to common code and makes kvm reuse it. This fixes both the ABI and correctness issues. Jeremy has acked the Xen changes.

Avi Kivity (3):
KVM: MMU: Fix oops on guest userspace access to guest pagetable
KVM: ioapic: fix lost interrupt when changing a device's irq
KVM: VMX: Fix host msr corruption with preemption enabled

Gerd Hoffmann (5):
x86: Add structs and functions for paravirt clocksource
x86: Make xen use the paravirt clocksource structs and functions
KVM: Make kvm host use the paravirt clocksource structs
x86: KVM guest: Use the paravirt clocksource structs and functions
KVM: Remove now unused structs from kvm_para.h

Marcelo Tosatti (4):
KVM: Fix race between timer migration and vcpu migration
KVM: close timer injection race window in __vcpu_run
KVM: MMU: Fix rmap_write_protect() hugepage iteration bug
KVM: MMU: large page update_pte issue with non-PAE 32-bit guests
(resend)

arch/x86/Kconfig              |    5 ++
arch/x86/kernel/Makefile      |    1 +
arch/x86/kernel/kvmclock.c    |   89 ++++++++++----------------
arch/x86/kernel/pvclock.c     |  141 +++++++++++++++++++++++++++++++++++++++++
arch/x86/kvm/i8254.c          |    9 ++-
arch/x86/kvm/lapic.c          |    1 +
arch/x86/kvm/mmu.c            |   19 +++---
arch/x86/kvm/vmx.c            |   19 +++---
arch/x86/kvm/x86.c            |   91 +++++++++++++++++++-------
arch/x86/xen/Kconfig          |    1 +
arch/x86/xen/time.c           |  132 ++++-----------------------------------
include/asm-x86/kvm_host.h    |    4 +-
include/asm-x86/kvm_para.h    |   18 -----
include/asm-x86/pvclock-abi.h |   42 ++++++++++++
include/asm-x86/pvclock.h     |   13 ++++
include/linux/kvm_host.h      |    1 +
include/xen/interface/xen.h   |    7 +-
virt/kvm/ioapic.c             |   31 +++------
18 files changed, 358 insertions(+), 266 deletions(-)

create mode 100644 arch/x86/kernel/pvclock.c
create mode 100644 include/asm-x86/pvclock-abi.h
create mode 100644 include/asm-x86/pvclock.h

Signature · 1 line
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
#1 lore raw
Quoted 7 lines · Avi Kivity

Linus, please pull from the repo and branch at:

git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git kvm-updates-2.6.26

to receive kvm updates for 2.6.26-rc7. The patches fix host oopses, guest interrupt loss, and total kvm clock borkage.

Avi, you _really_ need to start respecting the merge window.

If you can't learn, I will have to just stop pulling from you. This is simply too big for this late in the game.

I pulled, but I'm simply not going to continue doing this dance. I don't care much for virtualization, so I've let it slide, but you need to learn that

Quoted 1 line
18 files changed, 358 insertions(+), 266 deletions(-)

is simply not acceptable this late.

Linus

author
#2 lore raw
Quoted 14 lines · Linus Torvalds
Quoted 7 lines · Avi Kivity

Linus, please pull from the repo and branch at:

git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git kvm-updates-2.6.26

to receive kvm updates for 2.6.26-rc7. The patches fix host oopses, guest interrupt loss, and total kvm clock borkage.

Avi, you _really_ need to start respecting the merge window.

If you can't learn, I will have to just stop pulling from you. This is simply too big for this late in the game.

Quoted 8 lines

I pulled, but I'm simply not going to continue doing this dance. I don't care much for virtualization, so I've let it slide, but you need to learn that

Quoted 2 lines
18 files changed, 358 insertions(+), 266 deletions(-)

is simply not acceptable this late.

You're right, I guess I should have disabled kvm clock for 2.6.26 (which makes up the bulk of the changes) and re-enabled it for 2.6.27, but ended up not resisting the temptation.

Signature · 1 line
error compiling committee.c: too many arguments to function
#3 lore raw
In reply to Avi Kivity
Quoted 4 lines · Avi Kivity

Linus, please pull from the repo and branch at:

git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git
kvm-updates-2.6.26

I just pulled from Linus and now it stalls to boot at

[    0.616031] pnp: PnP ACPI init
[    0.628031] ACPI: bus type pnp registered
[    0.640031] pnp: PnP ACPI: found 7 devices
[    0.652031] ACPI: ACPI bus type pnp unregistered
[    0.660031] SCSI subsystem initialized
[    0.664031] PCI: Using ACPI for IRQ routing
[    0.692031] PCI-GART: No AMD northbridge found.

The kvm process is at 100% time. Taking the many problems I already reported about, 2.6.26 probably will be entirely broken regarding kvm :(

Thanks,
Bernd

#4 lore raw
Quoted 17 lines · Bernd Schubert
Quoted 4 lines · Avi Kivity

Linus, please pull from the repo and branch at:

git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git
kvm-updates-2.6.26

I just pulled from Linus and now it stalls to boot at

[    0.616031] pnp: PnP ACPI init
[    0.628031] ACPI: bus type pnp registered
[    0.640031] pnp: PnP ACPI: found 7 devices
[    0.652031] ACPI: ACPI bus type pnp unregistered
[    0.660031] SCSI subsystem initialized
[    0.664031] PCI: Using ACPI for IRQ routing
[    0.692031] PCI-GART: No AMD northbridge found.
Quoted 2 lines

The kvm process is at 100% time. Taking the many problems I already reported about, 2.6.26 probably will be entirely broken regarding kvm :(

Do you have CONFIG_KVM_CLOCK or CONFIG_KVM_GUEST enabled ?

There is a known problem with CONFIG_KVM_GUEST being worked on.

Can you provide this details, and pinpoint which option is the culprit?

#5 lore raw
Quoted 17 lines · Marcelo Tosatti
Quoted 16 lines · Bernd Schubert
Quoted 4 lines · Avi Kivity

Linus, please pull from the repo and branch at:

git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git
kvm-updates-2.6.26

I just pulled from Linus and now it stalls to boot at

[    0.616031] pnp: PnP ACPI init
[    0.628031] ACPI: bus type pnp registered
[    0.640031] pnp: PnP ACPI: found 7 devices
[    0.652031] ACPI: ACPI bus type pnp unregistered
[    0.660031] SCSI subsystem initialized
[    0.664031] PCI: Using ACPI for IRQ routing
[    0.692031] PCI-GART: No AMD northbridge found.
Quoted 8 lines
Quoted 2 lines

The kvm process is at 100% time. Taking the many problems I already reported about, 2.6.26 probably will be entirely broken regarding kvm :(

Do you have CONFIG_KVM_CLOCK or CONFIG_KVM_GUEST enabled ?

There is a known problem with CONFIG_KVM_GUEST being worked on.

Can you provide this details, and pinpoint which option is the culprit?

Just found out, it is CONFIG_KVM_CLOCK. With CONFIG_KVM_CLOCK=y it does boot fine.

Thanks,
Bernd

#6 lore raw
Quoted 21 lines · Bernd Schubert
Quoted 20 lines · Marcelo Tosatti
Quoted 18 lines · Bernd Schubert
Quoted 4 lines · Avi Kivity

Linus, please pull from the repo and branch at:

git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git
kvm-updates-2.6.26

I just pulled from Linus and now it stalls to boot at

[    0.616031] pnp: PnP ACPI init
[    0.628031] ACPI: bus type pnp registered
[    0.640031] pnp: PnP ACPI: found 7 devices
[    0.652031] ACPI: ACPI bus type pnp unregistered
[    0.660031] SCSI subsystem initialized
[    0.664031] PCI: Using ACPI for IRQ routing
[    0.692031] PCI-GART: No AMD northbridge found.

The kvm process is at 100% time. Taking the many problems I already reported about, 2.6.26 probably will be entirely broken regarding kvm :(

Quoted 8 lines
Quoted 5 lines

Do you have CONFIG_KVM_CLOCK or CONFIG_KVM_GUEST enabled ?

There is a known problem with CONFIG_KVM_GUEST being worked on.

Can you provide this details, and pinpoint which option is the culprit?

Just found out, it is CONFIG_KVM_CLOCK. With CONFIG_KVM_CLOCK=y it does boot fine.

You mean with CONFIG_KVM_CLOCK=n it boots fine, I suppose.

You should upgrade the guest kernel to the git tree, kvm clock changes break compatibility with older kernels.

#7 lore raw
Quoted 25 lines · Marcelo Tosatti
Quoted 24 lines · Bernd Schubert
Quoted 23 lines · Marcelo Tosatti
Quoted 16 lines · Bernd Schubert
Quoted 4 lines · Avi Kivity

Linus, please pull from the repo and branch at:

git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git
kvm-updates-2.6.26

I just pulled from Linus and now it stalls to boot at

[    0.616031] pnp: PnP ACPI init
[    0.628031] ACPI: bus type pnp registered
[    0.640031] pnp: PnP ACPI: found 7 devices
[    0.652031] ACPI: ACPI bus type pnp unregistered
[    0.660031] SCSI subsystem initialized
[    0.664031] PCI: Using ACPI for IRQ routing
[    0.692031] PCI-GART: No AMD northbridge found.
Quoted 3 lines

The kvm process is at 100% time. Taking the many problems I already reported about, 2.6.26 probably will be entirely broken regarding kvm :(

Do you have CONFIG_KVM_CLOCK or CONFIG_KVM_GUEST enabled ?

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

There is a known problem with CONFIG_KVM_GUEST being worked on.

Can you provide this details, and pinpoint which option is the culprit?

Just found out, it is CONFIG_KVM_CLOCK. With CONFIG_KVM_CLOCK=y it does boot fine.

You mean with CONFIG_KVM_CLOCK=n it boots fine, I suppose.

Oh sorry, this was supposed to be "With CONFIG_KVM_GUEST=y it boots fine". So yes, CONFIG_KVM_CLOCK is the culprit.

Quoted 3 lines

You should upgrade the guest kernel to the git tree, kvm clock changes break compatibility with older kernels.

This __is__ the after updating to recent git (before that my problem was different). Latest commit is

commit 543cf4cb3fe6f6cae3651ba918b9c56200b257d0

Author: Linus Torvalds <[email protected]>
Date:   Tue Jun 24 18:58:20 2008 -0700
    Linux 2.6.26-rc8

Thanks,
Bernd

#8 lore raw
In reply to Marcelo Tosatti
Quoted 7 lines · Marcelo Tosatti
Quoted 2 lines

Just found out, it is CONFIG_KVM_CLOCK. With CONFIG_KVM_CLOCK=y it does boot fine.

You mean with CONFIG_KVM_CLOCK=n it boots fine, I suppose.

You should upgrade the guest kernel to the git tree, kvm clock changes break compatibility with older kernels.

Err, I mean you have to upgrade the host kernel too.

#9 lore raw
Quoted 10 lines · Marcelo Tosatti
Quoted 7 lines · Marcelo Tosatti
Quoted 2 lines

Just found out, it is CONFIG_KVM_CLOCK. With CONFIG_KVM_CLOCK=y it does boot fine.

You mean with CONFIG_KVM_CLOCK=n it boots fine, I suppose.

You should upgrade the guest kernel to the git tree, kvm clock changes break compatibility with older kernels.

Err, I mean you have to upgrade the host kernel too.

Ah, unfortunately I can't do this easily :(
I'm presently on vacation and the host is my desktop at work, the risk to break something remotely is too high. And even when I'n back is a problem, unfortunately the host is a nvidia system and dual display only works with the binary only driver (*grr* why did I have to get a stupid nvidia system :
( ).

Thanks,
Bernd

#10 lore raw
In reply to Marcelo Tosatti
Quoted 4 lines

You mean with CONFIG_KVM_CLOCK=n it boots fine, I suppose.

You should upgrade the guest kernel to the git tree, kvm clock changes break compatibility with older kernels.

For completeness: older -rc kernels only, mixing -rc8 with 2.6.25 and older is fine.

cheers,
Gerd

Signature · 1 line
http://kraxel.fedorapeople.org/xenner/
#11 lore raw
Quoted 7 lines · Gerd Hoffmann
Quoted 4 lines

You mean with CONFIG_KVM_CLOCK=n it boots fine, I suppose.

You should upgrade the guest kernel to the git tree, kvm clock changes break compatibility with older kernels.

For completeness: older -rc kernels only, mixing -rc8 with 2.6.25 and older is fine.

Hmm, actually the host kernel is 2.6.24-ubuntu-something (due to this annoying required nvidia binary module). So it actually should work?

Thanks,
Bernd

#12 lore raw
Quoted 10 lines · Bernd Schubert
Quoted 6 lines · Gerd Hoffmann
Quoted 4 lines

You mean with CONFIG_KVM_CLOCK=n it boots fine, I suppose.

You should upgrade the guest kernel to the git tree, kvm clock changes break compatibility with older kernels.

For completeness: older -rc kernels only, mixing -rc8 with 2.6.25 and older is fine.

Hmm, actually the host kernel is 2.6.24-ubuntu-something (due to this annoying required nvidia binary module). So it actually should work?

Yes, should have worked (assuming it is 2.6.24-vanilla kvm host code, i.e. no kvm patches in and no external kvm module running).

Can you provide the full guest boot log?

cheers,
Gerd

Signature · 1 line
http://kraxel.fedorapeople.org/xenner/
#13 lore raw
In reply to Bernd Schubert
Quoted 4 lines · Bernd Schubert
Quoted 2 lines · Gerd Hoffmann
Quoted 2 lines

You mean with CONFIG_KVM_CLOCK=n it boots fine, I suppose.

Quoted 9 lines
Quoted 6 lines
Quoted 3 lines

You should upgrade the guest kernel to the git tree, kvm clock changes break compatibility with older kernels.

For completeness: older -rc kernels only, mixing -rc8 with 2.6.25 and older is fine.

Hmm, actually the host kernel is 2.6.24-ubuntu-something (due to this annoying required nvidia binary module). So it actually should work?

The ubuntu kernel has a newer KVM module backported to it so it's really 2.6.25-rcX.

Regards,

Anthony Liguori

Quoted 8 lines

Thanks,
Bernd

--
To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#14 lore raw

(copying the guilty party)

Quoted 1 line · Anthony Liguori

The ubuntu kernel has a newer KVM module backported to it so it's really 2.6.25-rcX.

That's a big no-no. We only guarantee binary compatibility for kernel.org releases. kvm-blah releases may break compatibility temporarily as issues are worked out.

Signature · 1 line
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
#15 lore raw
Quoted 5 lines · Avi Kivity
Quoted 2 lines

The ubuntu kernel has a newer KVM module backported to it so it's really 2.6.25-rcX.

That's a big no-no. We only guarantee binary compatibility for kernel.org releases. kvm-blah releases may break compatibility temporarily as issues are worked out.

I thought there was an ABI check of sorts in place that should take care of this?

Signature · 3 lines
Soren Hansen               | 
Virtualisation specialist  | Ubuntu Server Team
Canonical Ltd.             | http://www.ubuntu.com/
author
#16 lore raw
Quoted 5 lines · Soren Hansen
Quoted 3 lines · Avi Kivity
Quoted 3 lines

The ubuntu kernel has a newer KVM module backported to it so it's really 2.6.25-rcX.

Quoted 9 lines
Quoted 4 lines

That's a big no-no. We only guarantee binary compatibility for kernel.org releases. kvm-blah releases may break compatibility temporarily as issues are worked out.

I thought there was an ABI check of sorts in place that should take care of this?

There is, but it doesn't differentiate between variants of the ABI as it evolves. We probably ought to fix this by appending _EXPERIMENTAL to extensions while they are developed (or better, by considering at the result of KVM_CHECK_EXTENSION as a version number rather than a bool).

Signature · 1 line
error compiling committee.c: too many arguments to function
#17 lore raw
In reply to Avi Kivity
Quoted 5 lines · Avi Kivity
Quoted 2 lines

The ubuntu kernel has a newer KVM module backported to it so it's really 2.6.25-rcX.

That's a big no-no. We only guarantee binary compatibility for kernel.org releases. kvm-blah releases may break compatibility temporarily as issues are worked out.

Well, anyhow, let's focus on getting this fixed, shall we?

The kernel modules shipped in 2.6.24 was causing all sorts of issues, so in an effort to fix those, IIRC I grabbed what was in 2.6.25 at the time and backported that, so if I were to get this issue fixed, it should be sufficient to find anything that touches the kvm clock ABI between 2.6.25-rc<whatever I used> and 2.6.25 final. Does that sound about right?

I'm a bit confused about this, though. I was under the impression that for the KVM_CLOCK stuff to work, it'd would have to be in the host *and* the guest kernel, but our kernels don't have KVM_CLOCK enabled at all?

Hmm... Looking at the code, it seems it does require host support, but it's not #ifdef'ed, so that would explain my confusion..

Signature · 3 lines
Soren Hansen               | 
Virtualisation specialist  | Ubuntu Server Team
Canonical Ltd.             | http://www.ubuntu.com/
#18 lore raw
Quoted 8 lines · Soren Hansen

Well, anyhow, let's focus on getting this fixed, shall we?

The kernel modules shipped in 2.6.24 was causing all sorts of issues, so in an effort to fix those, IIRC I grabbed what was in 2.6.25 at the time and backported that, so if I were to get this issue fixed, it should be sufficient to find anything that touches the kvm clock ABI between 2.6.25-rc<whatever I used> and 2.6.25 final. Does that sound about right?

guest side: turn off CONFIG_KVM_CLOCK for kernels older than -rc8
host side:  either apply the kvmclock fixes or disable support by

removing kvm clock from the capabilities bit mask.

To fix the host you need this one:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=50d0a0f987b83a8dadb1134d834e35ec410392b5

Also this as dependency to make it build:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7af192c954017499ec163bc9dbaaee2e593d7ef2ke

Quoted 3 lines

I'm a bit confused about this, though. I was under the impression that for the KVM_CLOCK stuff to work, it'd would have to be in the host *and* the guest kernel, but our kernels don't have KVM_CLOCK enabled at all?

Host support doesn't depend on CONFIG_KVM_CLOCK.

HTH,
Gerd

Signature · 1 line
http://kraxel.fedorapeople.org/xenner/
#19 lore raw
Quoted 9 lines · Gerd Hoffmann
Quoted 6 lines

The kernel modules shipped in 2.6.24 was causing all sorts of issues, so in an effort to fix those, IIRC I grabbed what was in 2.6.25 at the time and backported that, so if I were to get this issue fixed, it should be sufficient to find anything that touches the kvm clock ABI between 2.6.25-rc<whatever I used> and 2.6.25 final. Does that sound about right?

guest side: turn off CONFIG_KVM_CLOCK for kernels older than -rc8 host
side: either apply the kvmclock fixes or disable support by removing kvm clock from the capabilities bit mask.

Thanks. This is very helpful!

I think disabling the kvm clock capability seems like the best option, since a cursory inspection suggests that that would not break the ABI. I'd have to run a test build to verify this, though.

Quoted 5 lines
Quoted 4 lines

I'm a bit confused about this, though. I was under the impression that for the KVM_CLOCK stuff to work, it'd would have to be in the host *and* the guest kernel, but our kernels don't have KVM_CLOCK enabled at all?

Host support doesn't depend on CONFIG_KVM_CLOCK.

Yeah, exactly. I didn't realise this until an hour ago.

Is this deliberately not ifdef'ed?

Signature · 3 lines
Soren Hansen               | 
Virtualisation specialist  | Ubuntu Server Team
Canonical Ltd.             | http://www.ubuntu.com/
author
#20 lore raw
In reply to Soren Hansen
Quoted 10 lines · Soren Hansen
Quoted 7 lines · Avi Kivity
Quoted 3 lines

The ubuntu kernel has a newer KVM module backported to it so it's really 2.6.25-rcX.

That's a big no-no. We only guarantee binary compatibility for kernel.org releases. kvm-blah releases may break compatibility temporarily as issues are worked out.

Quoted 9 lines

Well, anyhow, let's focus on getting this fixed, shall we?

The kernel modules shipped in 2.6.24 was causing all sorts of issues, so in an effort to fix those, IIRC I grabbed what was in 2.6.25 at the time and backported that, so if I were to get this issue fixed, it should be sufficient to find anything that touches the kvm clock ABI between 2.6.25-rc<whatever I used> and 2.6.25 final. Does that sound about right?

Yeah. To be on the safe side you can have KVM_CHECK_EXTENSION return false for KVM_CAP_CLOCKSOURCE.

Quoted 7 lines

I'm a bit confused about this, though. I was under the impression that for the KVM_CLOCK stuff to work, it'd would have to be in the host *and* the guest kernel, but our kernels don't have KVM_CLOCK enabled at all?

Hmm... Looking at the code, it seems it does require host support, but it's not #ifdef'ed, so that would explain my confusion..

Yeah, host and guest support are completely orthogonal.

Signature · 1 line
error compiling committee.c: too many arguments to function
#21 lore raw
Quoted 2 lines · Avi Kivity

Yeah. To be on the safe side you can have KVM_CHECK_EXTENSION return false for KVM_CAP_CLOCKSOURCE.

Oh! That's even better. Would that be sufficient? I mean, do all guest versions check this before trying to use the paravirt clock?

Signature · 3 lines
Soren Hansen               | 
Virtualisation specialist  | Ubuntu Server Team
Canonical Ltd.             | http://www.ubuntu.com/
author
#22 lore raw
Quoted 9 lines · Soren Hansen
Quoted 3 lines · Avi Kivity

Yeah. To be on the safe side you can have KVM_CHECK_EXTENSION return false for KVM_CAP_CLOCKSOURCE.

Oh! That's even better. Would that be sufficient? I mean, do all guest versions check this before trying to use the paravirt clock?

You need to disable the host side (KVM_CAP_CLOCKSOURCE) and the guest side (CONFIG_KVM_GUEST).

Signature · 1 line
error compiling committee.c: too many arguments to function
#23 lore raw
Quoted 6 lines · Avi Kivity
Quoted 4 lines
Quoted 2 lines

Yeah. To be on the safe side you can have KVM_CHECK_EXTENSION return false for KVM_CAP_CLOCKSOURCE.

Oh! That's even better. Would that be sufficient? I mean, do all guest versions check this before trying to use the paravirt clock?

You need to disable the host side (KVM_CAP_CLOCKSOURCE) and the guest side (CONFIG_KVM_GUEST).

Well, we don't have KVM_GUEST in the Ubuntu 8.04 kernels anyway (them being 2.6.24 based and all), so returning false for KVM_CAP_CLOCKSOURCE should be sufficient, I presume?

Signature · 3 lines
Soren Hansen               | 
Virtualisation specialist  | Ubuntu Server Team
Canonical Ltd.             | http://www.ubuntu.com/
author
#24 lore raw
Quoted 8 lines · Soren Hansen
Quoted 6 lines · Avi Kivity
Quoted 6 lines
Quoted 3 lines

Yeah. To be on the safe side you can have KVM_CHECK_EXTENSION return false for KVM_CAP_CLOCKSOURCE.

Oh! That's even better. Would that be sufficient? I mean, do all guest versions check this before trying to use the paravirt clock?

Quoted 9 lines
Quoted 3 lines

You need to disable the host side (KVM_CAP_CLOCKSOURCE) and the guest side (CONFIG_KVM_GUEST).

Well, we don't have KVM_GUEST in the Ubuntu 8.04 kernels anyway (them being 2.6.24 based and all), so returning false for KVM_CAP_CLOCKSOURCE should be sufficient, I presume?

Yes.

Signature · 1 line
error compiling committee.c: too many arguments to function
#25 lore raw
In reply to Avi Kivity
Quoted 6 lines · Avi Kivity

Gerd Hoffmann (5):
x86: Add structs and functions for paravirt clocksource
x86: Make xen use the paravirt clocksource structs and functions
KVM: Make kvm host use the paravirt clocksource structs
x86: KVM guest: Use the paravirt clocksource structs and functions
KVM: Remove now unused structs from kvm_para.h

Yeah, I was really expecting this to be .27 material. The Xen parts of the patch look OK, but I can't say I've tested them much - certainly not enough to be confident enough to push them in a late -rc.

J

author
#26 lore raw
Quoted 10 lines · Jeremy Fitzhardinge
Quoted 6 lines · Avi Kivity

Gerd Hoffmann (5):
x86: Add structs and functions for paravirt clocksource
x86: Make xen use the paravirt clocksource structs and functions
KVM: Make kvm host use the paravirt clocksource structs
x86: KVM guest: Use the paravirt clocksource structs and functions
KVM: Remove now unused structs from kvm_para.h

Yeah, I was really expecting this to be .27 material. The Xen parts of the patch look OK, but I can't say I've tested them much - certainly not enough to be confident enough to push them in a late -rc.

I thought I did mention this was for 2.6.26. If you are uncomfortable with this, I'll prepare patches that revert this and disable kvm clock for 2.6.26 instead.

Signature · 2 lines
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.