Skip to contentSkip to conversation

PATCH: drivers/mtd/jedec_flash.c (typo)

U-Boot-Users Jerry Hicks 3 participants 4 messages Jun 27, 2008 – Jul 8, 2008

lore
Share & tools
lore
#1 lore raw
Quoted 4 lines · In message <[email protected]> you wrote:

I noticed that the device id for AMD flash part AM29DL800BB is wrong.

Attached patch corrects it.

...

Review

Quoted 2 lines
(quoted diff) +1 -1
-#define AM29DL800BB	0x22C8
+#define AM29DL800BB	0x22CB

Hmmmm... I have but an old data sheet (Nov 2000) for this chip, which indeed says 22CB. But then, even the current Linux kernel tree has 22C8.

Can anybody with access to real hardware / current documentation comment?

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
We, the unwilling, led by the unknowing, are doing the impossible for
the ungrateful. We have done so much, for so long, with so little, we
are now qualified to do anything with nothing.
author
#2 lore raw
Quoted 13 lines · Wolfgang Denk
Quoted 4 lines · In message <[email protected]> you wrote:

I noticed that the device id for AMD flash part AM29DL800BB is wrong.

Attached patch corrects it.

...

Review

Quoted 2 lines
(quoted diff) +1 -1
-#define AM29DL800BB  0x22C8
+#define AM29DL800BB  0x22CB

Hmmmm... I have but an old data sheet (Nov 2000) for this chip, which indeed says 22CB. But then, even the current Linux kernel tree has 22C8.

Quoted 6 lines

Can anybody with access to real hardware / current documentation comment?

Best regards,

Wolfgang Denk

(I had a connectivity "burp" earlier when sending a reply.
Please excuse if double-posted)

We were using a custom driver written by Andy Lowe of Montavista. He had a #define local to our flash.c implementation when I noticed the discrepancy between his local definition and the one in the u-boot header.

On our hardware it works with 0x22CB but not with 0x22C8.

The current documentation from Spansion also shows it as 0x22CB.

http://www.spansion.com/datasheets/21519c4.pdf

Cheers,

Jerry.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20080706/efac2171/attachment.htm

#3 lore raw
Quoted 10 lines · Jerry Hicks

We were using a custom driver written by Andy Lowe of Montavista. He had a #define local to our flash.c implementation when I noticed the discrepancy between his local definition and the one in the u-boot header.

On our hardware it works with 0x22CB but not with 0x22C8.

The current documentation from Spansion also shows it as 0x22CB.

http://www.spansion.com/datasheets/21519c4.pdf

I created an "official" patch for this and applied it to the cfi_flash repository. I'll send the pull request soon.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================