Skip to contentSkip to conversation

Sparse warnings

DISCUSSION Larry Finger 2 participants 2 messages Jun 27, 2008

lore
Share & tools
lore
#0 lore raw

While checking the rtl8187 driver for sparse warnings, I discovered these:

CHECK drivers/net/wireless/hostap/hostap_80211_rx.c
drivers/net/wireless/hostap/hostap_80211_rx.c:128:34: warning: symbol 'hdr' shadows an earlier one drivers/net/wireless/hostap/hostap_80211_rx.c:67:29: originally declared here drivers/net/wireless/hostap/hostap_80211_rx.c:150:32: warning: symbol 'hdr' shadows an earlier one drivers/net/wireless/hostap/hostap_80211_rx.c:67:29: originally declared here
CHECK drivers/net/wireless/hostap/hostap_ap.c
drivers/net/wireless/hostap/hostap_ap.c:1933:18: warning: cast truncates bits from constant value (ffffffffffff3fff becomes 3fff)
CHECK drivers/net/wireless/hostap/hostap_main.c
drivers/net/wireless/hostap/hostap_main.c:597:5: warning: symbol 'hostap_80211_header_parse' was not declared. Should it be static?

Obviously, none of these cause any problems, but I'm reporting them just in case.

Larry

#1 lore raw
Quoted 3 lines · Larry Finger

While checking the rtl8187 driver for sparse warnings, I discovered these:

CHECK drivers/net/wireless/hostap/hostap_80211_rx.c

Larry, I'm sitting on a fix for that. Joini was unhappy about some radiotap changes, and I didn't have time to revisit it. Give me two hours, I'll send the uncontroversial parts.

Signature · 2 lines
Regards,
Pavel Roskin