Skip to contentSkip to conversation

sata_sil24: add DIDs for adaptec flavors

PATCH NAK Tejun Heo 3 participants 5 messages Jul 2, 2008 – Jul 4, 2008 libata

lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 sata_sil24: add DIDs for adaptec flavors

Adaptec uses different DIDs for 3132. Add them.

Reported by Travis Read.

Signed-off-by Tejun Heo <[email protected]>
Cc Travis Read <[email protected]>
---
 drivers/ata/sata_sil24.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/ata/sata_sil24.c +2 -0
index 8ee6b5b..5633a31 100644
@@ -372,6 +372,8 @@ static const struct pci_device_id sil24_pci_tbl[] = {
 	{ PCI_VDEVICE(CMD, 0x0242), BID_SIL3132 },
 	{ PCI_VDEVICE(CMD, 0x3131), BID_SIL3131 },
 	{ PCI_VDEVICE(CMD, 0x3531), BID_SIL3131 },
+	{ PCI_VDEVICE(CMD, 0x0242), BID_SIL3132 },
+	{ PCI_VDEVICE(CMD, 0x0244), BID_SIL3132 },
 
 	{ } /* terminate list */
 };
NAK
#1 lore raw
Quoted 6 lines · On Wed, 02 Jul 2008 11:52:09 +0900 Tejun Heo <[email protected]> wrote:

Adaptec uses different DIDs for 3132. Add them.

Reported by Travis Read.

Signed-off-by Tejun Heo <[email protected]>
Cc Travis Read <[email protected]>

NAK

drivers/ata/sata_sil24.c static const struct pci_device_id sil24_pci_tbl[] = { · line 376

Quoted 5 lines
drivers/ata/sata_sil24.c +2 -0
 	{ PCI_VDEVICE(CMD, 0x0242), BID_SIL3132 },
 	{ PCI_VDEVICE(CMD, 0x3131), BID_SIL3131 },
 	{ PCI_VDEVICE(CMD, 0x3531), BID_SIL3131 },
+	{ PCI_VDEVICE(CMD, 0x0242), BID_SIL3132 },
+	{ PCI_VDEVICE(CMD, 0x0244), BID_SIL3132 },

The first of those is a duplicate (see the top entry)

Alan

author
#2 lore raw
Quoted 12 lines · Alan Cox
Quoted 6 lines · On Wed, 02 Jul 2008 11:52:09 +0900 Tejun Heo <[email protected]> wrote:

Adaptec uses different DIDs for 3132. Add them.

Reported by Travis Read.

Signed-off-by Tejun Heo <[email protected]>
Cc Travis Read <[email protected]>

NAK

Quoted 7 lines

drivers/ata/sata_sil24.c static const struct pci_device_id sil24_pci_tbl[] = { · line 376

Quoted 5 lines
drivers/ata/sata_sil24.c +2 -0
 	{ PCI_VDEVICE(CMD, 0x0242), BID_SIL3132 },
 	{ PCI_VDEVICE(CMD, 0x3131), BID_SIL3131 },
 	{ PCI_VDEVICE(CMD, 0x3531), BID_SIL3131 },
+	{ PCI_VDEVICE(CMD, 0x0242), BID_SIL3132 },
+	{ PCI_VDEVICE(CMD, 0x0244), BID_SIL3132 },

The first of those is a duplicate (see the top entry)

Heh.. yeah. What was I thinking. Thanks for spotting it.

Signature · 1 line
tejun
author
#3 lore raw

PATCH 1/1 sata_sil24: add DID for another adaptec falvor

There's another DID used for Adaptec card. Add it.

Reported by Travis Read.

Signed-off-by Tejun Heo <[email protected]>
Cc Travis Read <[email protected]>
---
 drivers/ata/sata_sil24.c |    1 +
 1 file changed, 1 insertion(+)
drivers/ata/sata_sil24.c +1 -0
index 8ee6b5b..84ffcc2 100644
@@ -370,6 +370,7 @@ static const struct pci_device_id sil24_pci_tbl[] = {
 	{ PCI_VDEVICE(INTEL, 0x3124), BID_SIL3124 },
 	{ PCI_VDEVICE(CMD, 0x3132), BID_SIL3132 },
 	{ PCI_VDEVICE(CMD, 0x0242), BID_SIL3132 },
+	{ PCI_VDEVICE(CMD, 0x0244), BID_SIL3132 },
 	{ PCI_VDEVICE(CMD, 0x3131), BID_SIL3131 },
 	{ PCI_VDEVICE(CMD, 0x3531), BID_SIL3131 },
Applied
#4 lore raw

Re: [PATCH #upstream-fixes take#2] sata_sil24: add DID for another adaptec falvor

Quoted 15 lines · Tejun Heo

There's another DID used for Adaptec card. Add it.

Reported by Travis Read.

Signed-off-by Tejun Heo <[email protected]>
Cc Travis Read <[email protected]>
---
 drivers/ata/sata_sil24.c |    1 +
 1 file changed, 1 insertion(+)
drivers/ata/sata_sil24.c +0 -0
index 8ee6b5b..84ffcc2 100644

drivers/ata/sata_sil24.c static const struct pci_device_id sil24_pci_tbl[] = { · line 376

Quoted 7 lines
drivers/ata/sata_sil24.c +1 -0
@@ -370,6 +370,7 @@ static const struct pci_device_id sil24_pci_tbl[] = {
 	{ PCI_VDEVICE(INTEL, 0x3124), BID_SIL3124 },
 	{ PCI_VDEVICE(CMD, 0x3132), BID_SIL3132 },
 	{ PCI_VDEVICE(CMD, 0x0242), BID_SIL3132 },
+	{ PCI_VDEVICE(CMD, 0x0244), BID_SIL3132 },
 	{ PCI_VDEVICE(CMD, 0x3131), BID_SIL3131 },
 	{ PCI_VDEVICE(CMD, 0x3531), BID_SIL3131 },

applied