comedi: Fix include for do_div

PATCH In review Jan Kiszka 2 participants 5 messages Jul 4, 2008 – Jul 8, 2008 Comedi drivers

lore

Share & tools

lore

Jan Kiszka

author

2008-07-04 17:57 UTC #0 lore raw

PATCH 1/1 comedi: Fix include for do_div

Required with 2.6.26 where there is no more calc64. And asm/div64.h is what you actually want.

Jan

PS: Kernel-style reformatting would be nice - one day... :->

drivers/comedi/instruction.c +1 -1

Index: ksrc/drivers/comedi/instruction.c
===================================================================
@@ -25,7 +25,7 @@
 #include <linux/module.h>
 #include <linux/ioport.h>
 #include <linux/mman.h>
-#include <linux/calc64.h>
+#include <asm/div64.h>
 #include <asm/io.h>
 #include <asm/errno.h>

Alexis Berlemont

2008-07-07 21:12 UTC #1 lore raw

Hi,

Sorry for answering so lately, I was not at home the last four days.

Quoted 2 lines

Required with 2.6.26 where there is no more calc64. And asm/div64.h is what you actually want.

Thanks.

Quoted 1 line

PS: Kernel-style reformatting would be nice - one day... :->

Today or tomorrow, that sould be done.

Alexis.

Jan Kiszka

author

2008-07-08 07:45 UTC #2 lore raw

Quoted 8 lines · Alexis Berlemont

Hi,
Sorry for answering so lately, I was not at home the last four days.
Quoted 2 lines
Required with 2.6.26 where there is no more calc64. And asm/div64.h is what you actually want.
Thanks.

Sorry, but the committed fix is bogus for 2.6.26. I would suggest just to pick up what I proposed, kernel headers do the same since ages (including 2.4).

Jan

[email protected]

2008-07-08 10:35 UTC #3 lore raw

Hi,

Quoted 3 lines

Sorry, but the committed fix is bogus for 2.6.26. I would suggest just to pick up what I proposed, kernel headers do the same since ages (including 2.4).

Argh... I am an [CENSORED].

I missed everything, I was in another dimension. I had a too quick look at your fix (I saw linux/div64 instead of asm/div64) so I decided to put a temporary fix (as I was running out of time to get some 2.6.26-rcx sources).

I will fix that tonight.

Sorry I will be more careful (next time, I directly apply your patch).

Alexis.

Jan Kiszka

author

2008-07-08 10:49 UTC #4 lore raw

Quoted 8 lines · [email protected] wrote:

Hi,
Quoted 3 lines
Sorry, but the committed fix is bogus for 2.6.26. I would suggest just to pick up what I proposed, kernel headers do the same since ages (including 2.4).
Argh... I am an [CENSORED].

Quoted 7 lines

I missed everything, I was in another dimension. I had a too quick look at your fix (I saw linux/div64 instead of asm/div64) so I decided to put a temporary fix (as I was running out of time to get some 2.6.26-rcx sources).
I will fix that tonight.
Sorry I will be more careful (next time, I directly apply your patch).

(Please don't - I may post patches from other dimensions as well.) :)