Skip to contentSkip to conversation

PATCH: gspca-default-comp_fac.patch <resend>

PATCH Hans de Goede 1 participant 1 message Jul 5, 2008 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Jean,

This patch changes the default gspca comp_fac as 30% sometimes causes issues with the spca561, whose bayer compression does not allways achieve 30%.

I notice that you didn't apply this patch with the latest merging of my patches. Note that this patch is _really_ needed for the spca561 to work. Without it it works most of the time, but with some images it doesn't get a high enough compression and fails.

An other solution would be to add a cam specific get_buff_size op to the spca561 driver.

Regards,

Hans

This patch changes the default gspca comp_fac as 30% sometimes causes issues with the spca561, whose bayer compression does not allways achieve 30%.

linux/drivers/media/video/gspca/gspca.c +3 -1
diff -r 15974504cec1 linux/drivers/media/video/gspca/gspca.c
@@ -48,7 +48,9 @@
 
 static int video_nr = -1;
 
-static int comp_fac = 30;	/* Buffer size ratio when compressed in % */
+static int comp_fac = 40;	/* Buffer size ratio when compressed in %,
+				   Note 30% is too small for bayer level
+				   compression like the spca561 */
 
 #ifdef CONFIG_VIDEO_ADV_DEBUG
 int gspca_debug = D_ERR | D_PROBE;

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list