Skip to contentSkip to conversation

: net: fix dev_set_promiscuity() breakage

PATCH Applied Patrick McHardy 2 participants 2 messages Jul 6, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : net: fix dev_set_promiscuity() breakage

commit 7aaf76390d820383eb4069065ec2e1b5ee479ef9

Author: Patrick McHardy <[email protected]>
Date:   Mon Jul 7 00:21:09 2008 +0200

net: fix dev_set_promiscuity() breakage

Commit dad9b335 (netdevice: Fix promiscuity and allmulti overflow) broke dev_set_promiscuity() by returning on success without reprogramming the device.

net/core/dev.c +1 -1
index bfa9a6a..7593393 100644
@@ -2859,7 +2859,7 @@ int dev_set_promiscuity(struct net_device *dev, int inc)
 	int err;
 
 	err = __dev_set_promiscuity(dev, inc);
-	if (!err)
+	if (err < 0)
 		return err;
 	if (dev->flags != old_flags)
 		dev_set_rx_mode(dev);
maintainer Applied
#1 lore raw

From: Patrick McHardy <[email protected]>
Date: Mon, 07 Jul 2008 00:18:36 +0200

Quoted 7 lines

net: fix dev_set_promiscuity() breakage

Commit dad9b335 (netdevice: Fix promiscuity and allmulti overflow) broke dev_set_promiscuity() by returning on success without reprogramming the device.

Applied, thanks Patrick.