devcgroup: always show positive major/minor num

PATCH In review Li Zefan 1 participant 1 message Jul 8, 2008 Security (LSM)

Share & tools

Li Zefan

author

2008-07-08 01:52 UTC #0 lore raw

PATCH 1/3 devcgroup: always show positive major/minor num

 # echo "b $((0x7fffffff)):$((0x80000000)) rwm" > devices.allow
 # cat devices.list
 b 214748364:-21474836 rwm

though a major/minor number of 0x800000000 is meaningless, we should not cast it to a negative value.

Signed-off-by Li Zefan <[email protected]>

Acked-by Serge Hallyn <[email protected]>

---

No change for the first 2 patches, should these go into 2.6.26 ? Applied Paul M's comments to the 3rd one.

---
 security/device_cgroup.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

security/device_cgroup.c +2 -2

index fd764a0..1e2e28a 100644
@@ -222,7 +222,7 @@ static void devcgroup_destroy(struct cgroup_subsys *ss,
 #define DEVCG_DENY 2
 #define DEVCG_LIST 3
 
-#define MAJMINLEN 10
+#define MAJMINLEN 13
 #define ACCLEN 4
 
 static void set_access(char *acc, short access)

@@ -254,7 +254,7 @@ static void set_majmin(char *str, unsigned m)
 	if (m == ~0)
 		sprintf(str, "*");
 	else
-		snprintf(str, MAJMINLEN, "%d", m);
+		snprintf(str, MAJMINLEN, "%u", m);
 }
 
 static int devcgroup_seq_read(struct cgroup *cgroup, struct cftype *cft,

Signature · 1 line

1.5.4.rc3