block: allow deleting zero length partition

PATCH New Tejun Heo 1 participant 1 message Jul 14, 2008 Block layer

Share & tools

Tejun Heo

author

2008-07-14 06:07 UTC #0 lore raw

PATCH 1/1 block: allow deleting zero length partition

delete_partition() was noop for zero length partition. As the addition code allows creating zero lenght partition and deletion is assumed to always succeed, this causes memory leak for zero length partitions. Allow zero length partitions to end their meaningless lives.

While at it, allow deleting zero lenght partition via BLKPG_DEL_PARTITION ioctl too.

Signed-off-by Tejun Heo <[email protected]>

---
 block/ioctl.c         |    2 --
 fs/partitions/check.c |    2 --
 2 files changed, 0 insertions(+), 4 deletions(-)

block/ioctl.c +0 -2

index 52d6385..f0178c4 100644
@@ -67,8 +67,6 @@ static int blkpg_ioctl(struct block_device *bdev, struct blkpg_ioctl_arg __user
 		case BLKPG_DEL_PARTITION:
 			if (!disk->part[part-1])
 				return -ENXIO;
-			if (disk->part[part - 1]->nr_sects == 0)
-				return -ENXIO;
 			bdevp = bdget_disk(disk, part);
 			if (!bdevp)
 				return -ENOMEM;

fs/partitions/check.c +0 -2

index 6149e4b..3e0bf3f 100644
@@ -325,8 +325,6 @@ void delete_partition(struct gendisk *disk, int part)
 
 	if (!p)
 		return;
-	if (!p->nr_sects)
-		return;
 	disk->part[part-1] = NULL;
 	p->start_sect = 0;
 	p->nr_sects = 0;

Signature · 1 line

1.5.4.5