Skip to contentSkip to conversation

: garp: retry sending JoinIn messages after allocation failures

PATCH Applied Patrick McHardy 2 participants 2 messages Jul 15, 2008 – Jul 17, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Patrick McHardy

author
#0 lore raw

PATCH 1/1 : garp: retry sending JoinIn messages after allocation failures

commit ca42e467171a856e008b754b72c3446b70a7c48d

Author: Patrick McHardy <[email protected]>
Date:   Tue Jul 15 15:00:44 2008 +0200

garp: retry sending JoinIn messages after allocation failures

Increase reliability by retrying to send JoinIn messages after memory allocation failures on each TRANSMIT_PDU event until it succeeds.

Signed-off-by Patrick McHardy <[email protected]>
net/802/garp.c +4 -1
index 3b78f7b..1dcb066 100644
@@ -323,7 +323,10 @@ static void garp_attr_event(struct garp_applicant *app,
 	case GARP_ACTION_NONE:
 		break;
 	case GARP_ACTION_S_JOIN_IN:
-		garp_pdu_append_attr(app, attr, GARP_JOIN_IN);
+		/* When appending the attribute fails, don't update state in
+		 * order to retry on next TRANSMIT_PDU event. */
+		if (garp_pdu_append_attr(app, attr, GARP_JOIN_IN) < 0)
+			return;
 		break;
 	case GARP_ACTION_S_LEAVE_EMPTY:
 		garp_pdu_append_attr(app, attr, GARP_LEAVE_EMPTY);
maintainer Applied
#1 lore raw

From: Patrick McHardy <[email protected]>
Date: Tue, 15 Jul 2008 15:02:51 +0200

Quoted 6 lines

garp: retry sending JoinIn messages after allocation failures

Increase reliability by retrying to send JoinIn messages after memory allocation failures on each TRANSMIT_PDU event until it succeeds.

Signed-off-by Patrick McHardy <[email protected]>

Applied, thanks Patrick.