Skip to contentSkip to conversation

nf_nat_snmp_basic: fix compiler warning on 64-bit arch-s

PATCH In review Jan Beulich 2 participants 2 messages Jul 18, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nf_nat_snmp_basic: fix compiler warning on 64-bit arch-s

---
 net/ipv4/netfilter/nf_nat_snmp_basic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv4/netfilter/nf_nat_snmp_basic.c +1 -1
@@ -445,7 +445,7 @@ static unsigned char asn1_oid_decode(str
 	size = eoc - ctx->pointer + 1;
 
 	/* first subid actually encodes first two subids */
-	if (size < 2 || size > ULONG_MAX/sizeof(unsigned long))
+	if (size < 2 || size > UINT_MAX/sizeof(unsigned long))
 		return 0;
 
 	*oid = kmalloc(size * sizeof(unsigned long), GFP_ATOMIC);
#1 lore raw
Quoted 9 lines · Jan Beulich
---
 net/ipv4/netfilter/nf_nat_snmp_basic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

net/ipv4/netfilter/nf_nat_snmp_basic.c static unsigned char asn1_oid_decode(str · line 448

Quoted 5 lines
net/ipv4/netfilter/nf_nat_snmp_basic.c +1 -1
@@ -445,7 +445,7 @@ static unsigned char asn1_oid_decode(str
 	size = eoc - ctx->pointer + 1;
 
 	/* first subid actually encodes first two subids */
-	if (size < 2 || size > ULONG_MAX/sizeof(unsigned long))
+	if (size < 2 || size > UINT_MAX/sizeof(unsigned long))

Thanks, I already have a similar fix queued.