iwl-4965: test below 0 on unsigned num_tbs

PATCH In review roel kluin 1 participant 1 message Jul 22, 2008 Networking drivers (wireless)

lore

Share & tools

lore

roel kluin

author

2008-07-22 00:29 UTC #0 lore raw

PATCH 9/9 iwl-4965: test below 0 on unsigned num_tbs

num_tbs is unsigned so the test doesn't work.

Signed-off-by Roel Kluin <[email protected]>

---

drivers/net/wireless/iwlwifi/iwl-4965.c +1 -1

index de330ae..9e957a4 100644
@@ -3121,7 +3121,7 @@ int iwl4965_hw_txq_attach_buf_to_tfd(struct iwl_priv *priv, void *ptr,
 	u32 num_tbs = IWL_GET_BITS(*tfd, num_tbs);
 
 	/* Each TFD can point to a maximum 20 Tx buffers */
-	if ((num_tbs >= MAX_NUM_OF_TBS) || (num_tbs < 0)) {
+	if (num_tbs >= MAX_NUM_OF_TBS) {
 		IWL_ERROR("Error can not send more than %d chunks\n",
 			  MAX_NUM_OF_TBS);
 		return -EINVAL;