DCCP: Add check for missing sequence number in ICMPv6

PATCH Superseded Wei Yongjun 1 participant 1 message Jul 24, 2008 Networking

Share & tools

Wei Yongjun

author

2008-07-24 08:51 UTC #0 lore raw

PATCH 4/4 DCCP: Add check for missing sequence number in ICMPv6

RFC4340 said:
ICMP Datagram Too Big messages with incorrect or missing Sequence
Numbers may be ignored, or the DCCP implementation may lower the PMTU only temporarily in response.

This patch add the check for missing sequence number in ICMPv6 message.

Signed-off-by Wei Yongjun <[email protected]>

net/dccp/ipv6.c +6 -0

diff -Nurp a/net/dccp/ipv6.c b/net/dccp/ipv6.c
@@ -95,6 +95,12 @@ static void dccp_v6_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
 	int err;
 	__u64 seq;
 
+	if (skb->len < offset + 12 ||
+	    skb->len < offset + __dccp_basic_hdr_len(dh)) {
+		ICMP6_INC_STATS_BH(__in6_dev_get(skb->dev), ICMP_MIB_INERRORS);
+		return;
+	}
+
 	sk = inet6_lookup(dev_net(skb->dev), &dccp_hashinfo,
 			&hdr->daddr, dh->dccph_dport,
 			&hdr->saddr, dh->dccph_sport, inet6_iif(skb));