Skip to contentSkip to conversation

DCCP: Fix to check the sequence number in ICMP message

PATCH New Wei Yongjun 1 participant 1 message Jul 25, 2008 Networking

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/4 DCCP: Fix to check the sequence number in ICMP message

The payload of ICMP message is a part of the packet which send by ourself, so check the sequence number must used AWL and AWH, not SWL and SWH.

For example:

     Endpoint A                  Endpoint B

     DATA-ACK       -------->
     (SEQ=X)
                    <--------    ICMP (Fragmentation Needed)
                                 (SEQ=X)
---
 net/dccp/ipv4.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/dccp/ipv4.c +1 -1
index f966729..8fd4d57 100644
@@ -238,7 +238,7 @@ static void dccp_v4_err(struct sk_buff *skb, u32 info)
 	dp = dccp_sk(sk);
 	seq = dccp_hdr_seq(dh);
 	if ((1 << sk->sk_state) & ~(DCCPF_REQUESTING | DCCPF_LISTEN) &&
-	    !between48(seq, dp->dccps_swl, dp->dccps_swh)) {
+	    !between48(seq, dp->dccps_awl, dp->dccps_awh)) {
 		NET_INC_STATS_BH(net, LINUX_MIB_OUTOFWINDOWICMPS);
 		goto out;
 	}