Skip to contentSkip to conversation

Don't release root inode until finished using it

PATCH In review Lachlan McIlroy 3 participants 4 messages Aug 5, 2008 – Aug 6, 2008 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Don't release root inode until finished using it

During unmount we're releasing the last reference on the root inode before we've finished using it so move it after the XFS_SEND_UNMOUNT hook.

fs/xfs/linux-2.6/xfs_super.c +0 -0
@@ -1132,8 +1132,6 @@ xfs_fs_put_super(
	error = xfs_unmount_flush(mp, 0);
	WARN_ON(error);

- IRELE(rip);
-
/*
* If we're forcing a shutdown, typically because of a media error,
* we want to make sure we invalidate dirty pages that belong to
@@ -1149,6 +1147,8 @@ xfs_fs_put_super(

				unmount_event_flags);
	}

+ IRELE(rip);
+

	xfs_unmountfs(mp);
	xfs_icsb_destroy_counters(mp);
	xfs_close_devices(mp);
#1 lore raw
Quoted 3 lines · Lachlan McIlroy

During unmount we're releasing the last reference on the root inode before we've finished using it so move it after the XFS_SEND_UNMOUNT hook.

Looks ok.

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
[email protected]
#2 lore raw
In reply to Lachlan McIlroy

Looks good, but I've already sent a nicer version on the 26th:

[PATCH 1/6] move root inode IRELE into xfs_unmountfs

Sometimes I wish people would at least glance over my patches when they hit the list..

#3 lore raw
Quoted 7 lines · Christoph Hellwig

Looks good, but I've already sent a nicer version on the 26th:

[PATCH 1/6] move root inode IRELE into xfs_unmountfs

Sometimes I wish people would at least glance over my patches when they hit the list..

Some of us are trying to fix bugs and don't have time to look at every cleanup patch that hits the list.