i2c-i801: Fix checkpatch warnings
PATCH 1/1 i2c-i801: Fix checkpatch warnings
Fix all checkpatch warnings for the 2.6.27-rc3 driver and replace a lot of spaces by tabs.
Note: no functional changes are made.
---i2c-i801.c | 70 ++++++++++++++++++++++++++++++-------------------------------
1 file changed, 35 insertions(+), 35 deletions(-)
drivers/i2c/busses/i2c-i801.c +35 -35
@@ -22,32 +22,32 @@/* Supports the following Intel I/O Controller Hubs (ICH): -I/O Block I2C -region SMBus Block proc. block -Chip name PCI ID size PEC buffer call read +I/O Block I2C +region SMBus Block proc block +Chip name PCI ID size PEC buffer call read ---------------------------------------------------------------------- -82801AA (ICH) 0x2413 16 no no no no -82801AB (ICH0) 0x2423 16 no no no no -82801BA (ICH2) 0x2443 16 no no no no -82801CA (ICH3) 0x2483 32 soft no no no -82801DB (ICH4) 0x24c3 32 hard yes no no -82801E (ICH5) 0x24d3 32 hard yes yes yes -6300ESB 0x25a4 32 hard yes yes yes -82801F (ICH6) 0x266a 32 hard yes yes yes -6310ESB/6320ESB 0x269b 32 hard yes yes yes -82801G (ICH7) 0x27da 32 hard yes yes yes -82801H (ICH8) 0x283e 32 hard yes yes yes -82801I (ICH9) 0x2930 32 hard yes yes yes -Tolapai 0x5032 32 hard yes yes yes -ICH10 0x3a30 32 hard yes yes yes -ICH10 0x3a60 32 hard yes yes yes +82801AA (ICH) 0x2413 16 no no no no +82801AB (ICH0) 0x2423 16 no no no no +82801BA (ICH2) 0x2443 16 no no no no +82801CA (ICH3) 0x2483 32 soft no no no +82801DB (ICH4) 0x24c3 32 hard yes no no +82801E (ICH5) 0x24d3 32 hard yes yes yes +6300ESB 0x25a4 32 hard yes yes yes +82801F (ICH6) 0x266a 32 hard yes yes yes +6310ESB/6320ESB 0x269b 32 hard yes yes yes +82801G (ICH7) 0x27da 32 hard yes yes yes +82801H (ICH8) 0x283e 32 hard yes yes yes +82801I (ICH9) 0x2930 32 hard yes yes yes +Tolapai 0x5032 32 hard yes yes yes +ICH10 0x3a30 32 hard yes yes yes +ICH10 0x3a60 32 hard yes yes yes Features supported by this driver: -Software PEC no -Hardware PEC yes -Block buffer yes -Block process call transaction no -I2C block read transaction yes (doesn't use the block buffer) +Software PEC no +Hardware PEC yes +Block buffer yes +Block process call transaction no +I2C block read transaction yes (doesn't use the block buffer) See the file Documentation/i2c/busses/i2c-i801 for details. */
@@ -255,9 +255,9 @@ static void i801_wait_hwpec(void) }while ((!(status &SMBHSTSTS_INTR )) && (timeout++ <MAX_TIMEOUT )); -if (timeout >=MAX_TIMEOUT ) { +if (timeout >=MAX_TIMEOUT )dev_dbg (&I801_dev->dev,"PEC Timeout!\n" ); - } +outb_p (status,SMBHSTSTS ); }
@@ -338,9 +338,8 @@ static int i801_block_transaction_byte_bdo {msleep (1 ); status =inb_p (SMBHSTSTS ); - } -while ((!(status &SMBHSTSTS_BYTE_DONE )) - && (timeout++ <MAX_TIMEOUT )); + }while ((!(status &SMBHSTSTS_BYTE_DONE )) + && (timeout++ <MAX_TIMEOUT )); result =i801_check_post (status, timeout >=MAX_TIMEOUT );if (result <0 )
@@ -435,9 +434,9 @@ static int i801_block_transaction(union }/* Return negative errno on error. */ -static s32 i801_access (struct i2c_adapter * adap,u16 addr, +static s32 i801_access (struct i2c_adapter *adap,u16 addr,unsigned short flags,char read_write,u8 command, -int size,union i2c_smbus_data * data) +int size,union i2c_smbus_data *data) {int hwpec;int block =0 ;
@@ -506,7 +505,7 @@ static s32 i801_access(struct i2c_adapteelse outb_p (inb_p (SMBAUXCTL ) & (~SMBAUXCTL_CRC ),SMBAUXCTL ); -if (block) +if (block) ret =i801_block_transaction (data, read_write, size, hwpec);else ret =i801_transaction (xact |ENABLE_INT9 );
@@ -518,9 +517,9 @@ static s32 i801_access(struct i2c_adapteoutb_p (inb_p (SMBAUXCTL ) & ~(SMBAUXCTL_CRC |SMBAUXCTL_E32B ),SMBAUXCTL ); -if (block) +if (block)return ret; -if (ret) +if (ret)return ret;if ((read_write ==I2C_SMBUS_WRITE ) || (xact ==I801_QUICK ))return 0 ;
@@ -579,9 +578,10 @@ static struct pci_device_id i801_ids[] = { 0, } }; -MODULE_DEVICE_TABLE (pci, i801_ids); +MODULE_DEVICE_TABLE (pci, i801_ids); -static int __devinit i801_probe (struct pci_dev *dev,const struct pci_device_id *id) +static int __devinit i801_probe (struct pci_dev *dev, +const struct pci_device_id *id) {unsigned char temp;int err;
_______________________________________________
i2c mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/i2c
Hi Ivo,
Quoted 10 lines · Ivo Manca
Fix all checkpatch warnings for the 2.6.27-rc3 driver and replace a lot of spaces by tabs.
Note: no functional changes are made.
Signed-off-by Ivo Manca <[email protected]>--- i2c-i801.c | 70 ++++++++++++++++++++++++++++++------------------------------- 1 file changed, 35 insertions(+), 35 deletions(-)
I don't much like the conversion from spaces to tabs in the big header comment, so I reverted that part. The rest is good to have, thanks.
Signature · 6 lines
Jean Delvare _______________________________________________ i2c mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/i2c
Hey,
Quoted 6 lines
Hi Ivo,
I don't much like the conversion from spaces to tabs in the big header comment, so I reverted that part. The rest is good to have, thanks.
Okay, thanks for reverting it. I didn't really like the spaces, but it's your call :).
Ivo
_______________________________________________
i2c mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/i2c