Skip to contentSkip to conversation

Xen: Fix bug `do_IRQ: cannot handle IRQ -1 vector 0x6 cpu 1'

PATCH Jeremy Fitzhardinge 4 participants 5 messages Aug 18, 2008 – Aug 19, 2008 1 message not in the archive

lore
Share & tools
lore

Jeremy Fitzhardinge

author Acked-by
#1 lore raw
In reply to a message not in the archive
Quoted 8 lines · Alex Nixon

From: Alex Nixon <[email protected]>
Date: Mon, 18 Aug 2008 12:56:48 +0100
Subject: [PATCH] Xen: Fix bug `do_IRQ: cannot handle IRQ -1 vector 0x6 cpu 1'

Following commit 9c3f2468d8339866d9ef6a25aae31a8909c6be0d, do_IRQ() looks up the IRQ number in the per-cpu variable vector_irq.

This commit makes Xen initialise an identity vector_irq map for both X86_32 and X86_64.

Thanks Alex.

Ingo, please apply.

Quoted 26 lines
---
 arch/x86/xen/irq.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
arch/x86/xen/irq.c +0 -2
index 28b85ab..bb04260 100644
@@ -21,7 +21,6 @@ void xen_force_evtchn_callback(void)
 
 static void __init __xen_init_IRQ(void)
 {
-#ifdef CONFIG_X86_64
 	int i;
 
 	/* Create identity vector->irq map */
@@ -31,7 +30,6 @@ static void __init __xen_init_IRQ(void)
 		for_each_possible_cpu(cpu)
 			per_cpu(vector_irq, cpu)[i] = i;
 	}
-#endif	/* CONFIG_X86_64 */
 
 	xen_init_IRQ();
 }
#2 lore raw
Quoted 7 lines · Jeremy Fitzhardinge
Quoted 6 lines · Alex Nixon

From: Alex Nixon <[email protected]>
Date: Mon, 18 Aug 2008 12:56:48 +0100
Subject: [PATCH] Xen: Fix bug `do_IRQ: cannot handle IRQ -1 vector 0x6 cpu 1'

Following commit 9c3f2468d8339866d9ef6a25aae31a8909c6be0d, do_IRQ() looks up the IRQ number in the per-cpu variable vector_irq.

Quoted 8 lines
Quoted 2 lines

This commit makes Xen initialise an identity vector_irq map for both X86_32 and X86_64.

Thanks Alex.

Ingo, please apply.

i didnt get the original patches (they arent on lkml) - could you please resend them with your Acked-by line added as well?

by the looks of it, both are needed for v2.6.27, agreed?

Ingo

#3 lore raw
Quoted 15 lines · Ingo Molnar
Quoted 12 lines · Jeremy Fitzhardinge
Quoted 8 lines · Alex Nixon

From: Alex Nixon <[email protected]>
Date: Mon, 18 Aug 2008 12:56:48 +0100
Subject: [PATCH] Xen: Fix bug `do_IRQ: cannot handle IRQ -1 vector 0x6 cpu 1'

Following commit 9c3f2468d8339866d9ef6a25aae31a8909c6be0d, do_IRQ() looks up the IRQ number in the per-cpu variable vector_irq.

This commit makes Xen initialise an identity vector_irq map for both X86_32 and X86_64.

Thanks Alex.

Quoted 9 lines
Quoted 3 lines

Ingo, please apply.

i didnt get the original patches (they arent on lkml) - could you please resend them with your Acked-by line added as well?

by the looks of it, both are needed for v2.6.27, agreed?

no,

only tip/irq/sparseirq make 32 bit support per_cpu vector.

YH

#4 lore raw
In reply to Jeremy Fitzhardinge
Quoted 39 lines · Jeremy Fitzhardinge
Quoted 8 lines · Alex Nixon

From: Alex Nixon <[email protected]>
Date: Mon, 18 Aug 2008 12:56:48 +0100
Subject: [PATCH] Xen: Fix bug `do_IRQ: cannot handle IRQ -1 vector 0x6 cpu 1'

Following commit 9c3f2468d8339866d9ef6a25aae31a8909c6be0d, do_IRQ() looks up the IRQ number in the per-cpu variable vector_irq.

This commit makes Xen initialise an identity vector_irq map for both X86_32 and X86_64.

Thanks Alex.

Ingo, please apply.

Quoted 23 lines
---
 arch/x86/xen/irq.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
arch/x86/xen/irq.c +0 -2
index 28b85ab..bb04260 100644
@@ -21,7 +21,6 @@ void xen_force_evtchn_callback(void)
 
 static void __init __xen_init_IRQ(void)
 {
-#ifdef CONFIG_X86_64
      int i;
 
      /* Create identity vector->irq map */
@@ -31,7 +30,6 @@ static void __init __xen_init_IRQ(void)
              for_each_possible_cpu(cpu)
                      per_cpu(vector_irq, cpu)[i] = i;
      }
-#endif       /* CONFIG_X86_64 */
 
Quoted 3 lines

arch/x86/xen/irq.c static void __init __xen_init_IRQ(void) · line 35

Quoted 3 lines
arch/x86/xen/irq.c +0 -0
      xen_init_IRQ();
 }

Rusty,
can you check tip/master with lguest? wonder you need to do sth for lguest too. we are making 32 bit support per_cpu vector like 64 bit

also alok, can you check vmi etc...

Thanks

Yinghai Lu

#5 lore raw
Quoted 49 lines · Yinghai Lu
Quoted 39 lines · Jeremy Fitzhardinge
Quoted 8 lines · Alex Nixon

From: Alex Nixon <[email protected]>
Date: Mon, 18 Aug 2008 12:56:48 +0100
Subject: [PATCH] Xen: Fix bug `do_IRQ: cannot handle IRQ -1 vector 0x6 cpu 1'

Following commit 9c3f2468d8339866d9ef6a25aae31a8909c6be0d, do_IRQ() looks up the IRQ number in the per-cpu variable vector_irq.

This commit makes Xen initialise an identity vector_irq map for both X86_32 and X86_64.

Thanks Alex.

Ingo, please apply.

Quoted 23 lines
---
 arch/x86/xen/irq.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
arch/x86/xen/irq.c +0 -2
index 28b85ab..bb04260 100644
@@ -21,7 +21,6 @@ void xen_force_evtchn_callback(void)
 
 static void __init __xen_init_IRQ(void)
 {
-#ifdef CONFIG_X86_64
      int i;
 
      /* Create identity vector->irq map */
@@ -31,7 +30,6 @@ static void __init __xen_init_IRQ(void)
              for_each_possible_cpu(cpu)
                      per_cpu(vector_irq, cpu)[i] = i;
      }
-#endif       /* CONFIG_X86_64 */
 
Quoted 3 lines

arch/x86/xen/irq.c static void __init __xen_init_IRQ(void) · line 35

Quoted 3 lines
arch/x86/xen/irq.c +0 -0
      xen_init_IRQ();
 }

Rusty,
can you check tip/master with lguest? wonder you need to do sth for lguest too. we are making 32 bit support per_cpu vector like 64 bit

Quoted 1 line

also alok, can you check vmi etc...

Yes it crashes VMI too, i will get down to debug this maybe later in the day.
Thanks YH, for bringing this to my attention.

Alok.