Skip to contentSkip to conversation

POWERPC: duplicate test of MACIO_FLAG_SCCB_ON

PATCH In review roel kluin 2 participants 2 messages Aug 18, 2008

Subsystems (2)
PowerPC Linux for power macintosh
lore
Share & tools
lore

roel kluin

author
#0 lore raw

PATCH 1/1 POWERPC: duplicate test of MACIO_FLAG_SCCB_ON

untested, is it correct?

arch/powerpc/include/asm/pmac_feature.h:359:
#define MACIO_FLAG_SCCA_ON 0x00000001
#define MACIO_FLAG_SCCB_ON 0x00000002
---
duplicate test of MACIO_FLAG_SCCB_ON

Signed-off-by Roel Kluin <[email protected]>

---

arch/powerpc/platforms/powermac/feature.c +1 -1
index 5169ecc..e6c0040 100644
@@ -2677,7 +2677,7 @@ static void __init probe_one_macio(const char *name, const char *compat, int typ
 	macio_chips[i].of_node	= node;
 	macio_chips[i].type	= type;
 	macio_chips[i].base	= base;
-	macio_chips[i].flags	= MACIO_FLAG_SCCB_ON | MACIO_FLAG_SCCB_ON;
+	macio_chips[i].flags	= MACIO_FLAG_SCCA_ON | MACIO_FLAG_SCCB_ON;
 	macio_chips[i].name	= macio_names[type];
 	revp = of_get_property(node, "revision-id", NULL);
 	if (revp)
#1 lore raw
Quoted 1 line · roel kluin

untested, is it correct?

Your patch is correct. The bug is quite harmless thankfully :-)

Ben.

Quoted 21 lines

arch/powerpc/include/asm/pmac_feature.h:359:
#define MACIO_FLAG_SCCA_ON 0x00000001
#define MACIO_FLAG_SCCB_ON 0x00000002
---
duplicate test of MACIO_FLAG_SCCB_ON

Signed-off-by Roel Kluin <[email protected]>

---

arch/powerpc/platforms/powermac/feature.c +1 -1
index 5169ecc..e6c0040 100644
@@ -2677,7 +2677,7 @@ static void __init probe_one_macio(const char *name, const char *compat, int typ
 	macio_chips[i].of_node	= node;
 	macio_chips[i].type	= type;
 	macio_chips[i].base	= base;
-	macio_chips[i].flags	= MACIO_FLAG_SCCB_ON | MACIO_FLAG_SCCB_ON;
+	macio_chips[i].flags	= MACIO_FLAG_SCCA_ON | MACIO_FLAG_SCCB_ON;
 	macio_chips[i].name	= macio_names[type];
 	revp = of_get_property(node, "revision-id", NULL);
 	if (revp)