Skip to contentSkip to conversation

x86-64: fix two modpost warnings in mm/init_64.c

PATCH Rufus & Azrael 1 participant 1 message Aug 21, 2008

lore
Share & tools
lore
#0 lore raw
Quoted 23 lines

early_io{re,un}map() are __init and hence can't be called from __meminit functions.

---
  arch/x86/mm/init_64.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/mm/init_64.c +1 -1
@@ -241,7 +241,7 @@ static unsigned long __initdata table_st
  static unsigned long __meminitdata table_end;
  static unsigned long __meminitdata table_top;
 
-static __meminit void *alloc_low_page(unsigned long *phys)
+static __ref void *alloc_low_page(unsigned long *phys)
  {
  	unsigned long pfn = table_end++;
  	void *adr;

arch/x86/mm/init_64.c static __meminit void *alloc_low_page(un · line 268

Quoted 8 lines
arch/x86/mm/init_64.c +1 -1
@@ -262,7 +262,7 @@ static __meminit void *alloc_low_page(un
  	return adr;
  }
 
-static __meminit void unmap_low_page(void *adr)
+static __ref void unmap_low_page(void *adr)
  {
  	if (after_bootmem)
  		return;

Hi Jan,

I have tested your patch, it works fine on my amd64 box and the three section mismatches in cause have desapparead.

Thanks and regards.