Help with compiler warning
In drivers/pcmcia/cardbus.c, the following statement
memcpy_fromio(ptr, s->cb_cis_virt + addr, len);
generates the warning
CC [M] drivers/pcmcia/cardbus.oinclude/asm/io_32.h: In function ‘memcpy_fromio’:include/asm/io_32.h:151: warning: passing argument 2 of ‘__memcpy’ discards qualifiers from pointer target type
s->cb_cis_virt is "void __iomem" and addr is uint.
What cast does argument 2 need to silence the warning?
Thanks,
Larry
Quoted 6 lines · Larry Finger
In
drivers/pcmcia/cardbus.c, the following statementmemcpy_fromio(ptr, s->cb_cis_virt + addr, len);generates the warning
Quoted 8 lines
CC [M]
drivers/pcmcia/cardbus.oinclude/asm/io_32.h: In function ‘memcpy_fromio’:include/asm/io_32.h:151: warning: passing argument 2 of ‘__memcpy’ discards qualifiers from pointer target type
s->cb_cis_virtis "void__iomem" and addr is uint.What cast does argument 2 need to silence the warning?
memcpy_fromio takes a (const volatile void __iomem *) for the src address.
Benny
Quoted 9 lines
Thanks,
Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Quoted 12 lines · Benny Halevy
Quoted 11 lines · Larry Finger
In
drivers/pcmcia/cardbus.c, the following statementmemcpy_fromio(ptr, s->cb_cis_virt + addr, len);generates the warning
CC [M]
drivers/pcmcia/cardbus.oinclude/asm/io_32.h: In function ‘memcpy_fromio’:include/asm/io_32.h:151: warning: passing argument 2 of ‘__memcpy’ discards qualifiers from pointer target type
Quoted 6 lines
Quoted 3 lines
s->cb_cis_virtis "void__iomem" and addr is uint.What cast does argument 2 need to silence the warning?
memcpy_fromiotakes a (const volatile void__iomem*) for the src address.
So the culprit could be the volatile qualifier...
Quoted 12 lines
Benny
Quoted 8 lines
Thanks,
Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Quoted 12 lines · Benny Halevy
Quoted 11 lines · Benny Halevy
Quoted 10 lines · Larry Finger
In
drivers/pcmcia/cardbus.c, the following statementmemcpy_fromio(ptr, s->cb_cis_virt + addr, len);generates the warning
CC [M]
drivers/pcmcia/cardbus.oinclude/asm/io_32.h: In function ‘memcpy_fromio’:include/asm/io_32.h:151: warning: passing argument 2 of ‘__memcpy’ discards qualifiers from pointer target type
Quoted 6 lines
Quoted 4 lines
Quoted 3 lines
s->cb_cis_virtis "void__iomem" and addr is uint.What cast does argument 2 need to silence the warning?
memcpy_fromiotakes a (const volatile void__iomem*) for the src address.So the culprit could be the volatile qualifier...
Changing it to
memcpy_fromio(ptr, (const volatile void __iomem *)(s->cb_cis_virt + addr), len);
memcpy_fromio(ptr, (const volatile void __iomem *)s->cb_cis_virt + addr, len);
memcpy_fromio(ptr, (volatile void __iomem *)(s->cb_cis_virt + addr), len);
or
memcpy_fromio(ptr, (volatile void __iomem *)s->cb_cis_virt + addr, len);
makes no difference.
Thanks,
Larry
Quoted 9 lines · Larry Finger
Quoted 8 lines · Benny Halevy
Quoted 7 lines · Benny Halevy
Quoted 6 lines · Larry Finger
In
drivers/pcmcia/cardbus.c, the following statementmemcpy_fromio(ptr, s->cb_cis_virt + addr, len);generates the warning
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
CC [M]
drivers/pcmcia/cardbus.oinclude/asm/io_32.h: In function ‘memcpy_fromio’:include/asm/io_32.h:151: warning: passing argument 2 of ‘__memcpy’ discards qualifiers from pointer target type
s->cb_cis_virtis "void__iomem" and addr is uint.What cast does argument 2 need to silence the warning?
The cast needs to be in memcpy_fromio, but there is already one, so why do you get a warning in the first place?
Andreas.
Signature · 4 lines
Andreas Schwab, SuSE Labs, [email protected] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."