sctp: Fix the SNMP counter of SCTP_MIB_OUTOFBLUES

PATCH Superseded Wei Yongjun 1 participant 1 message Aug 27, 2008

Subsystems (2)

Networking SCTP protocol

lore

Share & tools

lore

Wei Yongjun

author

2008-08-27 02:43 UTC #0 lore raw

PATCH 1/1 sctp: Fix the SNMP counter of SCTP_MIB_OUTOFBLUES

RFC3873 defined SCTP_MIB_OUTOFBLUES:

sctpOutOfBlues OBJECT-TYPE

    SYNTAX         Counter32
    MAX-ACCESS     read-only
    STATUS         current

DESCRIPTION
"The number of out of the blue packets received by the host. An out of the blue packet is an SCTP packet correctly formed, including the proper checksum, but for which the receiver was unable to identify an appropriate association."
REFERENCE
"Section 8.4 in RFC2960 deals with the Out-Of-The-Blue
(OOTB) packet definition and procedures."

But OOTB packet INIT and INIT-ACK are not counted by SCTP_MIB_OUTOFBLUES.

Case 1(INIT):

Endpoint A Endpoint B
(CLOSED) (CLOSED)

INIT ---------->

           <----------    ABORT

Case 2(INIT-ACK):

Endpoint A Endpoint B
(CLOSED) (CLOSED)

INIT-ACK ---------->

            <----------   ABORT

This patch fixed the problem.

Signed-off-by Wei Yongjun <[email protected]>

---
 net/sctp/sm_statefuns.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

net/sctp/sm_statefuns.c +6 -2

index 0b49a56..24a3bce 100644
@@ -315,8 +315,10 @@ sctp_disposition_t sctp_sf_do_5_1B_init(const struct sctp_endpoint *ep,
 	/* If the packet is an OOTB packet which is temporarily on the
 	 * control endpoint, respond with an ABORT.
 	 */
-	if (ep = sctp_sk((sctp_get_ctl_sock()))->ep)
+	if (ep = sctp_sk((sctp_get_ctl_sock()))->ep) {
+		SCTP_INC_STATS(SCTP_MIB_OUTOFBLUES);
 		return sctp_sf_tabort_8_4_8(ep, asoc, type, arg, commands);
+	}
 
 	/* 3.1 A packet containing an INIT chunk MUST have a zero Verification
 	 * Tag.

@@ -635,8 +637,10 @@ sctp_disposition_t sctp_sf_do_5_1D_ce(const struct sctp_endpoint *ep,
 	/* If the packet is an OOTB packet which is temporarily on the
 	 * control endpoint, respond with an ABORT.
 	 */
-	if (ep = sctp_sk((sctp_get_ctl_sock()))->ep)
+	if (ep = sctp_sk((sctp_get_ctl_sock()))->ep) {
+		SCTP_INC_STATS(SCTP_MIB_OUTOFBLUES);
 		return sctp_sf_tabort_8_4_8(ep, asoc, type, arg, commands);
+	}
 
 	/* Make sure that the COOKIE_ECHO chunk has a valid length.
 	 * In this case, we check that we have enough for at least a

Signature · 1 line

1.5.3.8