ahci: disable PMP for marvell ahcis

PATCH Applied Tejun Heo 2 participants 2 messages Aug 29, 2008 – Sep 8, 2008 libata

lore

Share & tools

lore

Tejun Heo

author

2008-08-29 14:06 UTC #0 lore raw

PATCH 1/1 ahci: disable PMP for marvell ahcis

Marvell ahcis don't play nicely with PMPs. Disable it.

Reported by KueiHuan Chen in the following thread.

http://thread.gmane.org/gmane.linux.ide/33296

Signed-off-by Tejun Heo <[email protected]>

Cc KueiHuan Chen <[email protected]>

Cc Mark Lord <[email protected]>

---
 drivers/ata/ahci.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/ata/ahci.c +1 -1

index dc7596f..2806366 100644
@@ -420,7 +420,7 @@ static const struct ata_port_info ahci_port_info[] = {
 	/* board_ahci_mv */
 	{
 		AHCI_HFLAGS	(AHCI_HFLAG_NO_NCQ | AHCI_HFLAG_NO_MSI |
-				 AHCI_HFLAG_MV_PATA),
+				 AHCI_HFLAG_MV_PATA | AHCI_HFLAG_NO_PMP),
 		.flags		= ATA_FLAG_SATA | ATA_FLAG_NO_LEGACY |
 				  ATA_FLAG_MMIO | ATA_FLAG_PIO_DMA,
 		.pio_mask	= 0x1f, /* pio0-4 */

Jeff Garzik

Applied

2008-09-08 16:16 UTC #1 lore raw

Quoted 18 lines · Tejun Heo

Marvell ahcis don't play nicely with PMPs. Disable it.
Reported by KueiHuan Chen in the following thread.
http://thread.gmane.org/gmane.linux.ide/33296
Signed-off-by Tejun Heo <[email protected]>
Cc KueiHuan Chen <[email protected]>
Cc Mark Lord <[email protected]>
---
 drivers/ata/ahci.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/ahci.c +0 -0
index dc7596f..2806366 100644

drivers/ata/ahci.c static const struct ata_port_info ahci_port_info[] = { · line 425

Quoted 7 lines

drivers/ata/ahci.c +1 -1

@@ -420,7 +420,7 @@ static const struct ata_port_info ahci_port_info[] = {
 	/* board_ahci_mv */
 	{
 		AHCI_HFLAGS	(AHCI_HFLAG_NO_NCQ | AHCI_HFLAG_NO_MSI |
-				 AHCI_HFLAG_MV_PATA),
+				 AHCI_HFLAG_MV_PATA | AHCI_HFLAG_NO_PMP),
 		.flags		= ATA_FLAG_SATA | ATA_FLAG_NO_LEGACY |
 				  ATA_FLAG_MMIO | ATA_FLAG_PIO_DMA,

applied