Skip to contentSkip to conversation

buffer flag NONE is actually DONE

PATCH In review Lachlan McIlroy 2 participants 3 messages Sep 2, 2008 – Sep 3, 2008 XFS filesystem

lore
Share & tools
lore

Lachlan McIlroy

author
#0 lore raw

PATCH 1/1 buffer flag NONE is actually DONE

Amazing but true.

fs/xfs/xfsidbg.c +0 -0
@@ -1926,7 +1926,7 @@ static int	kdbm_iptraceaddr(

static char *bp_flag_vals[] = {
/* 0 */ "READ", "WRITE", "MAPPED", "PARTIAL", "ASYNC",

-/*  5 */ "NONE", "DELWRI",  "STALE", "FS_MANAGED", "FS_DATAIOD",
+/*  5 */ "DONE", "DELWRI",  "STALE", "FS_MANAGED", "FS_DATAIOD",

/* 10 */ "FORCEIO", "FLUSH", "READ_AHEAD", "DIRECTIO", "LOCK", /* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "KMEM_ALLOC", "RUN_QUEUES", /* 20 */ "PRIVATE_BH", "DELWRI_Q",

#1 lore raw

fs/xfs/xfsidbg.c 2008-09-02 14:51:04.000000000 +1000 static int kdbm_iptraceaddr( · line 1932

Quoted 13 lines · Lachlan McIlroy

Amazing but true.

fs/xfs/xfsidbg.c 2008-09-02 14:51:04.000000000 +1000 renamed from fs/xfs/xfsidbg.c 2008-09-02 14:52:11.000000000 +1000 +1 -1
@@ -1926,7 +1926,7 @@ static int    kdbm_iptraceaddr(
 
 static char    *bp_flag_vals[] = {
 /*  0 */ "READ", "WRITE", "MAPPED", "PARTIAL", "ASYNC",
-/*  5 */ "NONE", "DELWRI",  "STALE", "FS_MANAGED", "FS_DATAIOD",
+/*  5 */ "DONE", "DELWRI",  "STALE", "FS_MANAGED", "FS_DATAIOD",
 /* 10 */ "FORCEIO", "FLUSH", "READ_AHEAD", "DIRECTIO", "LOCK",
 /* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "KMEM_ALLOC", "RUN_QUEUES",
 /* 20 */ "PRIVATE_BH", "DELWRI_Q",

Looks good.

Quick look at possible mismatching names:

11 "FLUSH" vs "ORDERED"
18 "KMEM_ALLOC" vs "PAGES"
22 NULL vs "PAGE_LOCKED"

--Tim

author
#2 lore raw

How's this then? There's a few flags that don't exist anymore.

fs/xfs/xfsidbg.c +0 -0
@@ -1925,11 +1925,11 @@ static int	kdbm_iptraceaddr(

static char *bp_flag_vals[] = {
-/* 0 */ "READ", "WRITE", "MAPPED", "PARTIAL", "ASYNC",
-/* 5 */ "NONE", "DELWRI", "STALE", "FS_MANAGED", "FS_DATAIOD", -/* 10 */ "FORCEIO", "FLUSH", "READ_AHEAD", "DIRECTIO", "LOCK", -/* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "KMEM_ALLOC", "RUN_QUEUES", -/* 20 */ "PRIVATE_BH", "DELWRI_Q",
+/* 0 */ "READ", "WRITE", "MAPPED", "<unknown(3)>", "ASYNC", +/* 5 */ "DONE", "DELWRI", "STALE", "FS_MANAGED", "<unknown(9)>", +/* 10 */ "<unknown(10)>", "ORDERED", "READ_AHEAD", "<unknown(13)>", "LOCK", +/* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "PAGES", "RUN_QUEUES", +/* 20 */ "<unknown(20)>", "DELWRI_Q", "PAGE_LOCKED",

	 NULL };

static char *iomap_flag_vals[] = {

Quoted 25 lines · Timothy Shimmin

fs/xfs/xfsidbg.c 2008-09-02 14:51:04.000000000 +1000 static int kdbm_iptraceaddr( · line 1932

Quoted 13 lines · Lachlan McIlroy

Amazing but true.

fs/xfs/xfsidbg.c 2008-09-02 14:51:04.000000000 +1000 renamed from fs/xfs/xfsidbg.c 2008-09-02 14:52:11.000000000 +1000 +1 -1
@@ -1926,7 +1926,7 @@ static int    kdbm_iptraceaddr(
 
 static char    *bp_flag_vals[] = {
 /*  0 */ "READ", "WRITE", "MAPPED", "PARTIAL", "ASYNC",
-/*  5 */ "NONE", "DELWRI",  "STALE", "FS_MANAGED", "FS_DATAIOD",
+/*  5 */ "DONE", "DELWRI",  "STALE", "FS_MANAGED", "FS_DATAIOD",
 /* 10 */ "FORCEIO", "FLUSH", "READ_AHEAD", "DIRECTIO", "LOCK",
 /* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "KMEM_ALLOC", "RUN_QUEUES",
 /* 20 */ "PRIVATE_BH", "DELWRI_Q",

Looks good.

Quick look at possible mismatching names:

11 "FLUSH" vs "ORDERED"
18 "KMEM_ALLOC" vs "PAGES"
22 NULL vs "PAGE_LOCKED"

--Tim