Skip to contentSkip to conversation

efifb/imacfb consolidation + hardware support

PATCH In review Peter Jones 2 participants 3 messages Sep 4, 2008 – Sep 5, 2008 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 efifb/imacfb consolidation + hardware support

Hi. Below is a patch that removes imacfb entirely, merging its DMI table into the (otherwise very similar) efifb driver. This also adds hardware support for many of the newer Intel Apple hardware. This has been fairly well tested; we've been shipping it in Fedora for some time.

 Kconfig  |   15 --
 Makefile |    1
 efifb.c  |  191 ++++++++++++++++++++++++++++++--
 imacfb.c |  376 ---------------------------------------------------------------
 4 files changed, 184 insertions(+), 399 deletions(-)
drivers/video/Kconfig +3 -12
index 70d135e..be947ff 100644
@@ -687,23 +687,14 @@ config FB_VESA
 
 config FB_EFI
 	bool "EFI-based Framebuffer Support"
-	depends on (FB = y) && X86
-	select FB_CFB_FILLRECT
-	select FB_CFB_COPYAREA
-	select FB_CFB_IMAGEBLIT
-	help
-	  This is the EFI frame buffer device driver. If the firmware on
-	  your platform is UEFI2.0, select Y to add support for
-	  Graphics Output Protocol for early console messages to appear.
-
-config FB_IMAC
-	bool "Intel-based Macintosh Framebuffer Support"
 	depends on (FB = y) && X86 && EFI
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
 	help
-	  This is the frame buffer device driver for the Intel-based Macintosh
+	  This is the EFI frame buffer device driver. If the firmware on
+	  your platform is EFI 1.10 or UEFI 2.0, select Y to add support for
+	  using the EFI framebuffer as your console.
 
 config FB_N411
        tristate "N411 Apollo/Hecuba devkit support"
drivers/video/Makefile +0 -1
index a6b5529..2e0cd0c 100644
@@ -125,7 +125,6 @@ obj-$(CONFIG_FB_CARMINE)          += carminefb.o
 # Platform or fallback drivers go here
 obj-$(CONFIG_FB_UVESA)            += uvesafb.o
 obj-$(CONFIG_FB_VESA)             += vesafb.o
-obj-$(CONFIG_FB_IMAC)             += imacfb.o
 obj-$(CONFIG_FB_EFI)              += efifb.o
 obj-$(CONFIG_FB_VGA16)            += vga16fb.o
 obj-$(CONFIG_FB_OF)               += offb.o
drivers/video/efifb.c +181 -10

267 lines not on this page · raw message

drivers/video/imacfb.c +0 -376

376 lines not on this page · raw message

Signature · 1 line
        Peter
#1 lore raw
Quoted 2 lines

User-Agent: Thunderbird 2.0.0.14 (X11/20080501)

uh-oh.

Quoted 5 lines · On Thu, 04 Sep 2008 11:42:36 -0400 Peter Jones <[email protected]> wrote:

Hi. Below is a patch that removes imacfb entirely, merging its DMI table into the (otherwise very similar) efifb driver. This also adds hardware support for many of the newer Intel Apple hardware. This has been fairly well tested; we've been shipping it in Fedora for some time.

The patch was space-stuffed. I fixed that. Please see Documentation/email-clients.txt to fix it.

Please send a Signed-off-by: for this change.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

#2 lore raw
Quoted 7 lines · Andrew Morton
Quoted 1 line

User-Agent: Thunderbird 2.0.0.14 (X11/20080501)

uh-oh.

On Thu, 04 Sep 2008 11:42:36 -0400
Peter Jones <[email protected]> wrote:

Quoted 8 lines
Quoted 5 lines

Hi. Below is a patch that removes imacfb entirely, merging its DMI table into the (otherwise very similar) efifb driver. This also adds hardware support for many of the newer Intel Apple hardware. This has been fairly well tested; we've been shipping it in Fedora for some time.

The patch was space-stuffed. I fixed that. Please see Documentation/email-clients.txt to fix it.

Thanks for the pointer.

Quoted 1 line

Please send a Signed-off-by: for this change.

I'll assume that in this response is fine:

Signature · 7 lines
         Peter

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/