Skip to contentSkip to conversation

DVB Update [PATCH 22/31] multiproto tree

PATCH Manu Abraham 1 participant 1 message Sep 4, 2008 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw
Quoted 1 line

From a4d4b171211d0c71eda0f807506e905df2b9e4ef Mon Sep 17 00:00:00 2001

From: Manu Abraham <[email protected]>
Date: Thu, 4 Sep 2008 14:24:28 +0200
Subject: [PATCH] DVB fix broken backward compatibility for DVBFE_GET_PARAMS

DVBFE_GET_PARAMS 's backward compatibily was broken due to a wrong copy. Fix it.

Thanks to Marco Schluessler <[email protected]> for pointing out the bug.

From: Manu Abraham <[email protected]>

 dvb_frontend.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 1 line

From a4d4b171211d0c71eda0f807506e905df2b9e4ef Mon Sep 17 00:00:00 2001

From: Manu Abraham <[email protected]>
Date: Thu, 4 Sep 2008 14:24:28 +0200
Subject: [PATCH] DVB fix broken backward compatibility for DVBFE_GET_PARAMS

DVBFE_GET_PARAMS 's backward compatibily was broken due to a wrong copy. Fix it.

Thanks to Marco Schluessler <[email protected]> for pointing out the bug.

From: Manu Abraham <[email protected]>

drivers/media/dvb/dvb-core/dvb_frontend.c +1 -1
index 2b28bd1..24ae622 100644
@@ -1816,7 +1816,7 @@ static int dvb_frontend_ioctl(struct inode *inode, struct file *file,
 			memcpy(parg, &fepriv->fe_params, sizeof (struct dvbfe_params));
 			err = fe->ops.get_params(fe, (struct dvbfe_params *) parg);
 		} else if (fe->ops.get_frontend) {
-			err = fe->ops.get_frontend(fe, (struct dvb_frontend_parameters*) parg);
+			err = fe->ops.get_frontend(fe, &fepriv->parameters);
 			if (!err) {
 				if (olddrv_to_newapi(fe, &fepriv->fe_params, &fepriv->parameters, fe->ops.info.type) == -EINVAL)
 					printk("%s: ERROR !!! Converting Old parameters --> New parameters\n", __func__);