Skip to contentSkip to conversation

qemu compile warning

PATCH In review Jes Sorensen 2 participants 2 messages Sep 5, 2008 – Sep 7, 2008 KVM

lore
Share & tools
lore

Jes Sorensen

author
#0 lore raw

PATCH 1/1 qemu compile warning

Hi,

This one is more of a generic qemu nit, do you want to take it or should I send it elsewhere?

Cheers,
Jes

Fix type of nb_sectors to match parameter of bdrv_get_geometry().

Signed-off-by Jes Sorensen <[email protected]>
---
 qemu/block.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
qemu/block.c +2 -2
Index: kvm-userspace.git/qemu/block.c
===================================================================
@@ -771,7 +771,7 @@
     int ret, i, heads, sectors, cylinders;
     struct partition *p;
     uint32_t nr_sects;
-    int64_t nb_sectors;
+    uint64_t nb_sectors;
 
     buf = qemu_memalign(512, 512);
     if (buf == NULL)

@@ -819,7 +819,7 @@
 {
     int translation, lba_detected = 0;
     int cylinders, heads, secs;
-    int64_t nb_sectors;
+    uint64_t nb_sectors;
 
     /* if a geometry hint is available, use it */
     bdrv_get_geometry(bs, &nb_sectors);
#1 lore raw
Quoted 5 lines · Jes Sorensen

Hi,

This one is more of a generic qemu nit, do you want to take it or should I send it elsewhere?

Nest to post it on qemu-devel@, so everyone benefits.

Signature · 1 line
error compiling committee.c: too many arguments to function